8315130: java.lang.IllegalAccessError when processing classlist to create CDS archive #1835
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a error which significantly complicates the use of static CDS in some applications with user-provided class loaders (workarounds require either manually editing the generated CDS classlist which is error-prone, or switching to dynamic CDS which has its own implications, or rewriting the application which is not always possible).
The conflicts were trivial: a few neighboring methods missing from this version and not directly related to the change.
The PR depends on #1833 and #1834 though it can be rewritten not to if needed.
Testing besides the CI (performed on macos/arm64):
runtime/cds
, a minimal reproducer app described in the original bug report.Progress
Integration blocker
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1835/head:pull/1835
$ git checkout pull/1835
Update a local copy of the PR:
$ git checkout pull/1835
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1835/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1835
View PR using the GUI difftool:
$ git pr show -t 1835
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1835.diff
Using Webrev
Link to Webrev Comment