Skip to content

8348240: Remove SystemDictionaryShared::lookup_super_for_unregistered_class() #1834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: pr/1833
Choose a base branch
from

Conversation

TimPushkin
Copy link

@TimPushkin TimPushkin commented May 27, 2025

The original change cleaned up code of static CDS. I am backporting it as a dependency of JDK-8315130 which I am backporting next (#1835): without this change the backport JDK-8315130 would need to include some parts of this change and would also leave some code unused.

Resolved conflicts:

  • src/hotspot/share/cds/unregisteredClasses.cpp: bug fix JDK-8343416 is missing in this version but the backported change itself incorporates the bug fix (to verify I checked that the backport makes the test added in JDK-8343416 pass, but I did not include that test in this PR)
  • src/hotspot/share/cds/classListParser.*pp: constant pool resolution was added there in JDK 23/24 as part of Project Layden (JDK-8293980, JDK-8332176) — this required only insignificant changes to the backport
  • The rest of the conflicts were trivial (caused by renaming, neighboring code removal, copyright year updates)

The PR depends on #1833 though it can be rewritten not to if needed.

Testing besides the CI (performed on macos/arm64): runtime/cds, test added in JDK-8343416 (not included in the backport since that is a separate change).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8348240 needs maintainer approval
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Dependency #1833 must be integrated first

Issue

  • JDK-8348240: Remove SystemDictionaryShared::lookup_super_for_unregistered_class() (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1834/head:pull/1834
$ git checkout pull/1834

Update a local copy of the PR:
$ git checkout pull/1834
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1834/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1834

View PR using the GUI difftool:
$ git pr show -t 1834

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1834.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 27, 2025

👋 Welcome back tpushkin! A progress list of the required criteria for merging this PR into pr/1833 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 27, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 7f16a0875ced8669b9d2131c67496a66e74ea36f 8348240: Remove SystemDictionaryShared::lookup_super_for_unregistered_class() May 27, 2025
@openjdk
Copy link

openjdk bot commented May 27, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 27, 2025
@mlbridge
Copy link

mlbridge bot commented May 27, 2025

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 24, 2025

@TimPushkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@TimPushkin
Copy link
Author

/touch

Waiting for review

@openjdk
Copy link

openjdk bot commented Jun 24, 2025

@TimPushkin The pull request is being re-evaluated and the inactivity timeout has been reset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants