8348240: Remove SystemDictionaryShared::lookup_super_for_unregistered_class() #1834
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original change cleaned up code of static CDS. I am backporting it as a dependency of JDK-8315130 which I am backporting next (#1835): without this change the backport JDK-8315130 would need to include some parts of this change and would also leave some code unused.
Resolved conflicts:
src/hotspot/share/cds/unregisteredClasses.cpp
: bug fix JDK-8343416 is missing in this version but the backported change itself incorporates the bug fix (to verify I checked that the backport makes the test added in JDK-8343416 pass, but I did not include that test in this PR)src/hotspot/share/cds/classListParser.*pp
: constant pool resolution was added there in JDK 23/24 as part of Project Layden (JDK-8293980, JDK-8332176) — this required only insignificant changes to the backportThe PR depends on #1833 though it can be rewritten not to if needed.
Testing besides the CI (performed on macos/arm64):
runtime/cds
, test added in JDK-8343416 (not included in the backport since that is a separate change).Progress
Integration blocker
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1834/head:pull/1834
$ git checkout pull/1834
Update a local copy of the PR:
$ git checkout pull/1834
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1834/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1834
View PR using the GUI difftool:
$ git pr show -t 1834
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1834.diff
Using Webrev
Link to Webrev Comment