Skip to content

meta: ignore mailmap changes in linux ci #58356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

meta: ignore mailmap changes in linux ci #58356

merged 1 commit into from
May 16, 2025

Conversation

JonasBa
Copy link
Contributor

@JonasBa JonasBa commented May 16, 2025

This is ignored in test-macos, however the change was not ported to test-linux.

@JonasBa JonasBa added the fast-track PRs that do not need to wait for 48 hours to land. label May 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

Fast-track has been requested by @JonasBa. Please 👍 to approve.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 16, 2025
@JonasBa JonasBa mentioned this pull request May 16, 2025
Merged
trivikr
trivikr approved these changes May 16, 2025
View reviewed changes
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.mailmap was ignored in macos for long-running/flaky workflows in #40109

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label May 16, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 16, 2025
@nodejs-github-bot nodejs-github-bot merged commit b1d5987 into nodejs:main May 16, 2025
27 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in b1d5987

aduh95 pushed a commit that referenced this pull request May 20, 2025
@JonasBa @aduh95
meta: ignore mailmap changes in linux ci
570cb6f 
PR-URL: #58356
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@github-actions github-actions bot mentioned this pull request May 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panva panva panva approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@richardlau richardlau richardlau approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@JonasBa @nodejs-github-bot @panva @jasnell @lpinca @anonrig @richardlau @trivikr