Skip to content

doc: add JonasBa to collaborators #58355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

doc: add JonasBa to collaborators #58355

merged 1 commit into from
May 16, 2025

Conversation

JonasBa
Copy link
Contributor

@JonasBa JonasBa commented May 16, 2025

Fixes #57410

@JonasBa JonasBa added doc Issues and PRs related to the documentations. notable-change PRs with changes that should be highlighted in changelogs. fast-track PRs that do not need to wait for 48 hours to land. labels May 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

Fast-track has been requested by @JonasBa. Please 👍 to approve.

@github-actions GitHub Actions
Copy link
Contributor

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @JonasBa.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 16, 2025
jasnell
jasnell approved these changes May 16, 2025
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@anonrig
Copy link
Member

anonrig commented May 16, 2025

cc @nodejs/build it seems updating mailmap file requires "test-linux" github actions to pass.

@JonasBa
Copy link
Contributor Author

JonasBa commented May 16, 2025 •
edited
Loading

cc @nodejs/build it seems updating mailmap file requires "test-linux" github actions to pass.

Seems like we already ignore this in test-macos, but not in test-linux. I've went ahead and ported the change in #58356

mcollina
mcollina approved these changes May 16, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label May 16, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 16, 2025
@nodejs-github-bot nodejs-github-bot merged commit e1ab0d1 into nodejs:main May 16, 2025
35 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in e1ab0d1

aduh95 pushed a commit that referenced this pull request May 20, 2025
@JonasBa @aduh95
doc: add JonasBa to collaborators
9d35b4c 
Fixes: #57410
PR-URL: #58355
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@github-actions github-actions bot mentioned this pull request May 20, 2025
Open
nodejs-github-bot added a commit that referenced this pull request May 20, 2025
@nodejs-github-bot
2025-05-21, Version 24.1.0 (Current)
587a88b 
Notable changes:

doc:
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
fs:
  * (SEMVER-MINOR) add to `Dir` support for explicit resource management (Antoine du Hamel) #58206
test_runner:
  * Revert "test_runner: change ts default glob (Théo LUDWIG) #58202

PR-URL: #58406
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@panva panva panva approved these changes

@jasnell jasnell jasnell approved these changes

@anonrig anonrig anonrig approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@richardlau richardlau richardlau approved these changes

@legendecas legendecas legendecas approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nominating @jonasba to be a collaborator