Skip to content

2025-05-21, Version 24.1.0 (Current) #58406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 78 commits into
base: v24.x
Choose a base branch
from
Open

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 20, 2025

Notable Changes

  • [9d35b4ce95] - doc: add JonasBa to collaborators (Jonas Badalic) #58355
  • [b7d1bfa7b4] - doc: add puskin to collaborators (Giovanni Bucci) #58308
  • [fcead7c28e] - (SEMVER-MINOR) fs: add to Dir support for explicit resource management (Antoine du Hamel) #58206
  • [f7041b9369] - Revert "test_runner: change ts default glob" (Théo LUDWIG) #58202
Commits
  • [b33e8d2a71] - async_hooks: ensure AsyncLocalStore instances work isolated (Gerhard Stöbich) #58149
  • [a1b078b18c] - buffer: give names to Buffer.prototype.*Write() functions (Livia Medeiros) #58258
  • [4c967b73c3] - buffer: use constexpr where possible (Yagiz Nizipli) #58141
  • [327095a928] - build: fix uvwasi pkgname (Antoine du Hamel) #58270
  • [2e54653d3d] - build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch (RafaelGSS) #58090
  • [7e4453fe93] - build: escape > metachar in vcbuild (Gerhard Stöbich) #58157
  • [7dabf079b1] - child_process: give names to promisified exec() and execFile() (LiviaMedeiros) #57916
  • [a896eff1f2] - crypto: handle missing OPENSSL_TLS_SECURITY_LEVEL (Shelley Vohr) #58103
  • [6403aa458f] - crypto: merge CipherBase.initiv into constructor (Tobias Nießen) #58166
  • [30897d915c] - deps: V8: backport 1d3362c55396 (Shu-yu Guo) #58230
  • [63f5d69d2b] - deps: V8: cherry-pick 4f38995c8295 (Shu-yu Guo) #58230
  • [5a5f6bb1d4] - deps: V8: cherry-pick 044b9b6f589d (Rezvan Mahdavi Hezaveh) #58230
  • [db57f0a4c0] - deps: patch V8 to 13.6.233.10 (Michaël Zasso) #58230
  • [f54a7a44ab] - Revert "deps: patch V8 to support compilation with MSVC" (Michaël Zasso) #58187
  • [e3193eeca4] - Revert "deps: always define V8_EXPORT_PRIVATE as no-op" (Michaël Zasso) #58187
  • [e75ecf8ad1] - Revert "deps: disable V8 concurrent sparkplug compilation" (Michaël Zasso) #58187
  • [a0ca15558d] - deps: update llhttp to 9.3.0 (Fedor Indutny) #58144
  • [90d4c11992] - deps: update amaro to 0.5.3 (Node.js GitHub Bot) #58174
  • [9d35b4ce95] - doc: add JonasBa to collaborators (Jonas Badalic) #58355
  • [2676ca0cf5] - doc: add latest security release steward (Rafael Gonzaga) #58339
  • [c35cc1bdd9] - doc: document default test-reporter change (Nico Jansen) #58302
  • [2bb433d4a5] - doc: fix CryptoKey.algorithm type and other interfaces in webcrypto.md (Filip Skokan) #58294
  • [f04f09d783] - doc: mark the callback argument of crypto.generatePrime as mandatory (Allon Murienik) #58299
  • [3b9b010844] - doc: remove comma delimiter mention on permissions doc (Rafael Gonzaga) #58297
  • [f0cf1a028d] - doc: make Stability labels not sticky in Stability index (Livia Medeiros) #58291
  • [a1b937bdee] - doc: update commit-queue documentation (Dario Piotrowicz) #58275
  • [b7d1bfa7b4] - doc: add puskin to collaborators (Giovanni Bucci) #58308
  • [fc30cdd8d2] - doc: update stability status for diagnostics_channel to experimental (Idan Goshen) #58261
  • [290a5ab8ca] - doc: clarify napi_get_value_string_* for bufsize 0 (Tobias Nießen) #58158
  • [c26863a683] - doc: fix typo of file http.md, outgoingMessage.setTimeout section (yusheng chen) #58188
  • [62dbd36dcb] - doc: update return types for eventNames method in EventEmitter (Yukihiro Hasegawa) #58083
  • [130c135f38] - fs: add support for URL for fs.glob's cwd option (Antoine du Hamel) #58182
  • [fcead7c28e] - (SEMVER-MINOR) fs: add to Dir support for explicit resource management (Antoine du Hamel) #58206
  • [655326ba9f] - fs: glob is stable, so should not emit experimental warnings (Théo LUDWIG) #58236
  • [6ebcce7625] - fs: ensure dir.read() does not throw synchronously (Antoine du Hamel) #58228
  • [7715722323] - http: remove unused functions and add todos (Yagiz Nizipli) #58143
  • [74a807e31f] - http,https: give names to anonymous or misnamed functions (Livia Medeiros) #58180
  • [24a9aefb08] - http2: add diagnostics channel 'http2.client.stream.start' (Darshan Sen) #58292
  • [2cb86a3cd6] - http2: add diagnostics channel 'http2.client.stream.created' (Darshan Sen) #58246
  • [8f1aee90d9] - http2: give name to promisified connect() (LiviaMedeiros) #57916
  • [b66f1b0be6] - inspector: support for worker inspection in chrome devtools (Shima Ryuhei) #56759
  • [868e72e367] - lib: fix sourcemaps with ts module mocking (Marco Ippolito) #58193
  • [570cb6f6b6] - meta: ignore mailmap changes in linux ci (Jonas Badalic) #58356
  • [b94f63b865] - module: handle instantiated async module jobs in require(esm) (Joyee Cheung) #58067
  • [714b706f2e] - repl: add proper vertical cursor movements (Giovanni Bucci) #58003
  • [629a954477] - repl: add possibility to edit multiline commands while adding them (Giovanni Bucci) #58003
  • [17746129f3] - sqlite: set name and length on sqlite.backup() (Livia Medeiros) #58251
  • [908782b1c0] - sqlite: add build option to build without sqlite (Michael Dawson) #58122
  • [a92a4074e4] - src: remove unused internalVerifyIntegrity internal binding (Dario Piotrowicz) #58285
  • [e0355b71ba] - src: add a variant of ToV8Value() for primitive arrays (Aditi) #57576
  • [cb24fc71c4] - src: remove unused checkMessagePort internal binding (Dario Piotrowicz) #58267
  • [4db5d0bc49] - src: remove unused shouldRetryAsESM internal binding (Dario Piotrowicz) #58265
  • [3b8d4e32ca] - src: add a couple fast apis in node_os (James M Snell) #58210
  • [a135c0aea3] - src: remove unneeded explicit V8 flags (Michaël Zasso) #58230
  • [abeb5c4cdc] - src: fix module buffer allocation (X-BW) #57738
  • [9ca4b46eb3] - src: use String::WriteV2() in TwoByteValue (Tobias Nießen) #58164
  • [bb28e2bfd7] - src: remove overzealous tcsetattr error check (Ben Noordhuis) #58200
  • [329e008e73] - src: refactor WriteUCS2 and remove flags argument (Tobias Nießen) #58163
  • [c815f29d61] - src: remove NonCopyableMaybe (Tobias Nießen) #58168
  • [685d137dec] - test: reduce iteration count in test-child-process-stdout-flush-exit (Antoine du Hamel) #58273
  • [40dc092e25] - test: remove unnecessary console.log from test-repl-null-thrown (Dario Piotrowicz) #58281
  • [a3af644dda] - test: allow tmpDir.path to be modified (Aviv Keller) #58173
  • [97f80374a6] - test: add Float16Array to common.getArrayBufferViews() (Livia Medeiros) #58233
  • [65683735ab] - test: fix executable flags (Livia Medeiros) #58250
  • [ebb82aa1c3] - test: deflake test-http2-client-socket-destroy (Luigi Pinca) #58212
  • [eb4f130b17] - test: remove Float16Array flag (Livia Medeiros) #58184
  • [09a85fdeb1] - test: skip test-buffer-tostring-rangeerror when low on memory (Ruben Bridgewater) #58142
  • [65446632b1] - test: reduce flakiness in test-heapdump-http2 (Joyee Cheung) #58148
  • [f7041b9369] - Revert "test_runner: change ts default glob" (Théo LUDWIG) #58202
  • [287454298d] - test_runner: unify --require and --import behavior when isolation none (Pietro Marchini) #57924
  • [6301b003f7] - tools: ignore deps/ and benchmark/ for CodeQL (Rafael Gonzaga) #58254
  • [2d5de7e309] - tools: add read permission to workflows that read contents (Antoine du Hamel) #58255
  • [b8d4715527] - tools: support environment variables via comments (Pietro Marchini) #58186
  • [d8e88f2c17] - typings: add missing typings for TypedArray (Jason Zhang) #58248
  • [4c6f73c5d5] - url: improve performance of the format function (Giovanni Bucci) #57099
  • [94c720c4ee] - util: add internal assignFunctionName() function (LiviaMedeiros) #57916
  • [3ed159afd1] - watch: fix watch args not being properly filtered (Dario Piotrowicz) #58279

puskin and others added 30 commits May 16, 2025 07:04
PR-URL: #57099
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #57916
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #57916
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #57916
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #58083
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
PR-URL: #58003
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
PR-URL: #58003
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
By the time the response event is emitted on the client's side, the
file may have already been fully piped and the stream pipe
may have been destroyed, so the test should not look for the
stream pipe in the snapshot.

PR-URL: #58148
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Escape the > metachar in vcbuild.bat to avoid that a file named as the
major node version number is created.

PR-URL: #58157
Refs: #57991
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #58141
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
I added this class in 823d86c in 2018
when we did not yet use `std::optional`. The last uses were removed in
5b9bf39, so remove it.

Refs: #24234
Refs: #55368
PR-URL: #58168
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Avoid that one AsyncLocalStore instance changes the state of another
AsyncLocalStore instance by restoring only the owned store instead
the complete AsyncContextFrame.

PR-URL: #58149
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Co-Authored-By: richardlau - Richard Lau <[email protected]>
PR-URL: #58090
Refs: #57934
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #58174
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
[email protected] optimizes header value parsing on ARM Neon/WASM, and adds
support for a protocol callback for use outside of the typical HTTP
setting (RTSP/ICE).

PR-URL: #58144
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Now that `CipherBase.init` has been removed, instances of the class are
always initialized by a call to `initiv` immediately after the
constructor has returned. Instead of calling into C++ twice from
`createCipherBase`, pass all required arguments to the constructor and
fully initialize the instance before the constructor returns.

PR-URL: #58166
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This has shown up as RangeError: Array buffer allocation failed and
it should be totally fine to skip this test in case the memory is low.

PR-URL: #58142
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #58184
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #58122
Reviewed-By: Edy Silva <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This reverts commit 57699ff.

PR-URL: #58187
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
This reverts commit ffadf35.

PR-URL: #58187
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
This reverts commit 0f98039.

PR-URL: #58187
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
This change refactors `StringBytes::WriteUCS2()` in multiple ways.

The `flags` argument being passed to `WriteUCS2()` is not useful: the
only really relevant flag is `NO_NULL_TERMINATION` since V8 ignores
`REPLACE_INVALID_UTF8`, `HINT_MANY_WRITES_EXPECTED`, and
`PRESERVE_ONE_BYTE_NULL` for UTF-16 strings. However, `WriteUCS2()`
might not null-terminate the result correctly regardless of whether
`NO_NULL_TERMINATION` is set because it makes multiple calls to
`String::Write()` internally. For these reasons, this patch removes the
`flags` argument entirely and always assumes `NO_NULL_TERMINATION`.

Next, this patch replaces the calls to the deprecated function
`String::Write()` with calls to the new function `String::WriteV2()`,
which always succeeds and always writes a predictable number of
characters, removing the need to deal with a return value here.

Lastly, this patch simplifies the implementation of `WriteUCS2()` and
computes the exact number of characters `nchars` from the beginning,
removing the need to later check again if the number of characters is
zero.

PR-URL: #58163
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #58193
Fixes: #58119
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
When require(esm) encounters a cached module job that is instantiated
but not yet evaluated, run the evaluation. This catches an edge case
previously missed in #57187.

PR-URL: #58067
Fixes: #58061
Reviewed-By: Jacob Smith <[email protected]>
Node calls tcsetattr on exit to reset the tty to its state on program
start. Good idea in general but tcsetattr can fail for a number of
reasons and since there really isn't anything we can do about it
at that point, simply ignore the error instead of aborting with
an inscrutable error message.

Most of the time it'll be fine because the most common failure is when
the user has already logged off and there isn't anything to restore in
the first place.

Fixes: #51519
PR-URL: #58200
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
PR-URL: #58143
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Since `String::Write()` is deprecated, use `String::WriteV2()` instead.

PR-URL: #58164
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This reverts commit 9df0ff7.

PR-URL: #58202
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
aduh95 and others added 19 commits May 16, 2025 07:07
PR-URL: #58270
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #58261
Fixes: #58234
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Edy Silva <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Fixes: #58088
PR-URL: #58308
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
update the commit-queue contributing documentation by:
 - removing the references of the feature being experimental
 - clarifying that it applies to mergeable pull requests

PR-URL: #58275
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
currently when --watch is used, the argv arguments that
the target script receives are filtered so that they don't
include watch related arguments, however the current
filtering logic is incorrect and it causes some watch values
to incorrectly pass the filtering, the changes here address
such issue

PR-URL: #58279
Fixes: #57124
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #58281
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #58273
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #58291
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Dario Piotrowicz <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Signed-off-by: Darshan Sen <[email protected]>
PR-URL: #58292
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #58297
Fixes: #58287
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Edy Silva <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
The current documentation lists the `callback` argument of
`crypto.generatePrime` as optional (it's surrounded by square
brackets), but this is incorrect - calling the function without a
callback will result in an `ERR_INVALID_ARG_TYPE` error:

For the record, the correct way to generate a prime synchronously,
without a callback, is to use the `generatePrimeSync` API.

This patch fixes the documentation and marks the callback argument as
mandatory. The `options` (second) argument, is indeed optional, and
is marked as such.

Fixes: #58298
PR-URL: #58299
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Edy Silva <[email protected]>
PR-URL: #58294
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Document the change made in #54548

PR-URL: #58302
Fixes: #58301
Refs: #54548
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
PR-URL: #58339
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: #58254
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #58356
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Fixes: #57410
PR-URL: #58355
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Notable changes:

doc:
  * add JonasBa to collaborators (Jonas Badalic) #58355
  * add puskin to collaborators (Giovanni Bucci) #58308
fs:
  * (SEMVER-MINOR) add to `Dir` support for explicit resource management (Antoine du Hamel) #58206
test_runner:
  * Revert "test_runner: change ts default glob (Théo LUDWIG) #58202

PR-URL: #58406
@github-actions github-actions bot added release Issues and PRs related to Node.js releases. v24.x v24.x v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch. labels May 20, 2025
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/crypto
  • @nodejs/gyp
  • @nodejs/http
  • @nodejs/net
  • @nodejs/security-wg
  • @nodejs/typescript
  • @nodejs/v8-update

@aduh95 aduh95 marked this pull request as ready for review May 20, 2025 18:03
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label May 20, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 20, 2025
Copy link

codecov bot commented May 20, 2025

Codecov Report

Attention: Patch coverage is 95.89235% with 29 lines in your changes missing coverage. Please review.

Project coverage is 90.24%. Comparing base (f7b92d7) to head (587a88b).
Report is 4 commits behind head on v24.x.

Files with missing lines Patch % Lines
lib/internal/modules/esm/module_job.js 79.41% 7 Missing ⚠️
src/crypto/crypto_cipher.cc 64.70% 2 Missing and 4 partials ⚠️
src/inspector_io.cc 91.11% 1 Missing and 3 partials ⚠️
src/inspector/target_agent.cc 95.83% 0 Missing and 3 partials ⚠️
src/inspector_agent.cc 93.54% 0 Missing and 2 partials ⚠️
src/util-inl.h 86.66% 0 Missing and 2 partials ⚠️
lib/internal/readline/interface.js 99.48% 1 Missing ⚠️
lib/internal/test_runner/utils.js 66.66% 1 Missing ⚠️
src/module_wrap.cc 87.50% 0 Missing and 1 partial ⚠️
src/node_sqlite.cc 66.66% 0 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##            v24.x   #58406      +/-   ##
==========================================
+ Coverage   90.13%   90.24%   +0.10%     
==========================================
  Files         630      632       +2     
  Lines      186650   187024     +374     
  Branches    36638    36711      +73     
==========================================
+ Hits       168245   168775     +530     
+ Misses      11199    11043     -156     
  Partials     7206     7206              
Files with missing lines Coverage Δ
lib/_http_outgoing.js 95.76% <100.00%> (+<0.01%) ⬆️
lib/_http_server.js 96.99% <100.00%> (-0.08%) ⬇️
lib/child_process.js 97.75% <100.00%> (+<0.01%) ⬆️
lib/events.js 99.75% <100.00%> (ø)
lib/fs.js 98.29% <ø> (-0.01%) ⬇️
lib/https.js 99.30% <100.00%> (ø)
...nternal/async_local_storage/async_context_frame.js 100.00% <100.00%> (ø)
lib/internal/buffer.js 98.58% <100.00%> (+0.08%) ⬆️
lib/internal/crypto/cipher.js 98.26% <100.00%> (-0.01%) ⬇️
lib/internal/fs/dir.js 94.45% <100.00%> (-0.60%) ⬇️
... and 49 more

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Issues and PRs related to Node.js releases. v24.x v24.x v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.