-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move support to v2.7.x and v3.1.0 #64
Conversation
a96a5fc
to
063707b
Compare
@pablogs9 as I said here, to get this working we would need to update some points:
Also I'm taking some time to refactor the zephyr transports for serial to use the up to date DT macros instead of using device labels, this is compatible across zephyr releases and scalable as long Zephyr evolves, probably will push this PR today or tomorrow. |
Sure, I will take some time to look into :) |
@mergify backport humble galactic foxy |
✅ Backports have been created
|
Signed-off-by: Pablo Garrido <[email protected]> Fix Signed-off-by: Pablo Garrido <[email protected]> Fix Signed-off-by: Pablo Garrido <[email protected]> Use ubuntu 20.04 Signed-off-by: Pablo Garrido <[email protected]> Update cmake Signed-off-by: Pablo Garrido <[email protected]> Fix env Signed-off-by: Pablo Garrido <[email protected]> Fix Signed-off-by: Pablo Garrido <[email protected]> Deprecate v2.4.0 Signed-off-by: Pablo Garrido <[email protected]> Update Signed-off-by: Pablo Garrido <[email protected]> Update Readme Signed-off-by: Pablo Garrido <[email protected]> Fix CMake Signed-off-by: Pablo Garrido <[email protected]> Update Signed-off-by: Pablo Garrido <[email protected]>
This reverts commit 64370f1.
Signed-off-by: Pablo Garrido <[email protected]>
6f8d44e
to
d4a8906
Compare
Signed-off-by: Pablo Garrido <[email protected]>
Signed-off-by: Pablo Garrido <[email protected]>
Signed-off-by: Pablo Garrido <[email protected]>
Signed-off-by: Pablo Garrido <[email protected]>
modules/libmicroros/microros_transports/serial-usb/microros_transports.c
Outdated
Show resolved
Hide resolved
modules/libmicroros/microros_transports/serial-usb/microros_transports.c
Outdated
Show resolved
Hide resolved
Signed-off-by: Pablo Garrido <[email protected]>
Signed-off-by: Pablo Garrido <[email protected]>
* Add v2.7.0 and v3.1.0 Signed-off-by: Pablo Garrido <[email protected]> Fix Signed-off-by: Pablo Garrido <[email protected]> Fix Signed-off-by: Pablo Garrido <[email protected]> Use ubuntu 20.04 Signed-off-by: Pablo Garrido <[email protected]> Update cmake Signed-off-by: Pablo Garrido <[email protected]> Fix env Signed-off-by: Pablo Garrido <[email protected]> Fix Signed-off-by: Pablo Garrido <[email protected]> Deprecate v2.4.0 Signed-off-by: Pablo Garrido <[email protected]> Update Signed-off-by: Pablo Garrido <[email protected]> Update Readme Signed-off-by: Pablo Garrido <[email protected]> Fix CMake Signed-off-by: Pablo Garrido <[email protected]> Update Signed-off-by: Pablo Garrido <[email protected]> * Revert "Add v2.7.0 and v3.1.0" This reverts commit 64370f1. * Initial Signed-off-by: Pablo Garrido <[email protected]> * Update Signed-off-by: Pablo Garrido <[email protected]> * Update Signed-off-by: Pablo Garrido <[email protected]> * Fix Signed-off-by: Pablo Garrido <[email protected]> * Move 2.7.2 to new ci Signed-off-by: Pablo Garrido <[email protected]> * Deprecate <v2.7 Signed-off-by: Pablo Garrido <[email protected]> * Readme Signed-off-by: Pablo Garrido <[email protected]> (cherry picked from commit 07797df) # Conflicts: # .github/workflows/nightly.yml
* Add v2.7.0 and v3.1.0 Signed-off-by: Pablo Garrido <[email protected]> Fix Signed-off-by: Pablo Garrido <[email protected]> Fix Signed-off-by: Pablo Garrido <[email protected]> Use ubuntu 20.04 Signed-off-by: Pablo Garrido <[email protected]> Update cmake Signed-off-by: Pablo Garrido <[email protected]> Fix env Signed-off-by: Pablo Garrido <[email protected]> Fix Signed-off-by: Pablo Garrido <[email protected]> Deprecate v2.4.0 Signed-off-by: Pablo Garrido <[email protected]> Update Signed-off-by: Pablo Garrido <[email protected]> Update Readme Signed-off-by: Pablo Garrido <[email protected]> Fix CMake Signed-off-by: Pablo Garrido <[email protected]> Update Signed-off-by: Pablo Garrido <[email protected]> * Revert "Add v2.7.0 and v3.1.0" This reverts commit 64370f1. * Initial Signed-off-by: Pablo Garrido <[email protected]> * Update Signed-off-by: Pablo Garrido <[email protected]> * Update Signed-off-by: Pablo Garrido <[email protected]> * Fix Signed-off-by: Pablo Garrido <[email protected]> * Move 2.7.2 to new ci Signed-off-by: Pablo Garrido <[email protected]> * Deprecate <v2.7 Signed-off-by: Pablo Garrido <[email protected]> * Readme Signed-off-by: Pablo Garrido <[email protected]> (cherry picked from commit 07797df) # Conflicts: # .github/workflows/nightly.yml
* Add v2.7.0 and v3.1.0 Signed-off-by: Pablo Garrido <[email protected]> Fix Signed-off-by: Pablo Garrido <[email protected]> Fix Signed-off-by: Pablo Garrido <[email protected]> Use ubuntu 20.04 Signed-off-by: Pablo Garrido <[email protected]> Update cmake Signed-off-by: Pablo Garrido <[email protected]> Fix env Signed-off-by: Pablo Garrido <[email protected]> Fix Signed-off-by: Pablo Garrido <[email protected]> Deprecate v2.4.0 Signed-off-by: Pablo Garrido <[email protected]> Update Signed-off-by: Pablo Garrido <[email protected]> Update Readme Signed-off-by: Pablo Garrido <[email protected]> Fix CMake Signed-off-by: Pablo Garrido <[email protected]> Update Signed-off-by: Pablo Garrido <[email protected]> * Revert "Add v2.7.0 and v3.1.0" This reverts commit 64370f1. * Initial Signed-off-by: Pablo Garrido <[email protected]> * Update Signed-off-by: Pablo Garrido <[email protected]> * Update Signed-off-by: Pablo Garrido <[email protected]> * Fix Signed-off-by: Pablo Garrido <[email protected]> * Move 2.7.2 to new ci Signed-off-by: Pablo Garrido <[email protected]> * Deprecate <v2.7 Signed-off-by: Pablo Garrido <[email protected]> * Readme Signed-off-by: Pablo Garrido <[email protected]> (cherry picked from commit 07797df) # Conflicts: # .github/workflows/ci.yml # .github/workflows/nightly.yml # README.md
* Move support to v2.7.x and v3.1.0 (#64) * Add v2.7.0 and v3.1.0 Signed-off-by: Pablo Garrido <[email protected]> Fix Signed-off-by: Pablo Garrido <[email protected]> Fix Signed-off-by: Pablo Garrido <[email protected]> Use ubuntu 20.04 Signed-off-by: Pablo Garrido <[email protected]> Update cmake Signed-off-by: Pablo Garrido <[email protected]> Fix env Signed-off-by: Pablo Garrido <[email protected]> Fix Signed-off-by: Pablo Garrido <[email protected]> Deprecate v2.4.0 Signed-off-by: Pablo Garrido <[email protected]> Update Signed-off-by: Pablo Garrido <[email protected]> Update Readme Signed-off-by: Pablo Garrido <[email protected]> Fix CMake Signed-off-by: Pablo Garrido <[email protected]> Update Signed-off-by: Pablo Garrido <[email protected]> * Revert "Add v2.7.0 and v3.1.0" This reverts commit 64370f1. * Initial Signed-off-by: Pablo Garrido <[email protected]> * Update Signed-off-by: Pablo Garrido <[email protected]> * Update Signed-off-by: Pablo Garrido <[email protected]> * Fix Signed-off-by: Pablo Garrido <[email protected]> * Move 2.7.2 to new ci Signed-off-by: Pablo Garrido <[email protected]> * Deprecate <v2.7 Signed-off-by: Pablo Garrido <[email protected]> * Readme Signed-off-by: Pablo Garrido <[email protected]> (cherry picked from commit 07797df) # Conflicts: # .github/workflows/ci.yml # .github/workflows/nightly.yml # README.md * Fix Signed-off-by: Pablo Garrido <[email protected]> * Fix Signed-off-by: Pablo Garrido <[email protected]> Co-authored-by: Pablo Garrido <[email protected]>
* Move support to v2.7.x and v3.1.0 (#64) * Add v2.7.0 and v3.1.0 Signed-off-by: Pablo Garrido <[email protected]> Fix Signed-off-by: Pablo Garrido <[email protected]> Fix Signed-off-by: Pablo Garrido <[email protected]> Use ubuntu 20.04 Signed-off-by: Pablo Garrido <[email protected]> Update cmake Signed-off-by: Pablo Garrido <[email protected]> Fix env Signed-off-by: Pablo Garrido <[email protected]> Fix Signed-off-by: Pablo Garrido <[email protected]> Deprecate v2.4.0 Signed-off-by: Pablo Garrido <[email protected]> Update Signed-off-by: Pablo Garrido <[email protected]> Update Readme Signed-off-by: Pablo Garrido <[email protected]> Fix CMake Signed-off-by: Pablo Garrido <[email protected]> Update Signed-off-by: Pablo Garrido <[email protected]> * Revert "Add v2.7.0 and v3.1.0" This reverts commit 64370f1. * Initial Signed-off-by: Pablo Garrido <[email protected]> * Update Signed-off-by: Pablo Garrido <[email protected]> * Update Signed-off-by: Pablo Garrido <[email protected]> * Fix Signed-off-by: Pablo Garrido <[email protected]> * Move 2.7.2 to new ci Signed-off-by: Pablo Garrido <[email protected]> * Deprecate <v2.7 Signed-off-by: Pablo Garrido <[email protected]> * Readme Signed-off-by: Pablo Garrido <[email protected]> (cherry picked from commit 07797df) # Conflicts: # .github/workflows/nightly.yml * Fix Signed-off-by: Pablo Garrido <[email protected]> * Fix Signed-off-by: Pablo Garrido <[email protected]> Co-authored-by: Pablo Garrido <[email protected]>
* Move support to v2.7.x and v3.1.0 (#64) * Add v2.7.0 and v3.1.0 Signed-off-by: Pablo Garrido <[email protected]> Fix Signed-off-by: Pablo Garrido <[email protected]> Fix Signed-off-by: Pablo Garrido <[email protected]> Use ubuntu 20.04 Signed-off-by: Pablo Garrido <[email protected]> Update cmake Signed-off-by: Pablo Garrido <[email protected]> Fix env Signed-off-by: Pablo Garrido <[email protected]> Fix Signed-off-by: Pablo Garrido <[email protected]> Deprecate v2.4.0 Signed-off-by: Pablo Garrido <[email protected]> Update Signed-off-by: Pablo Garrido <[email protected]> Update Readme Signed-off-by: Pablo Garrido <[email protected]> Fix CMake Signed-off-by: Pablo Garrido <[email protected]> Update Signed-off-by: Pablo Garrido <[email protected]> * Revert "Add v2.7.0 and v3.1.0" This reverts commit 64370f1. * Initial Signed-off-by: Pablo Garrido <[email protected]> * Update Signed-off-by: Pablo Garrido <[email protected]> * Update Signed-off-by: Pablo Garrido <[email protected]> * Fix Signed-off-by: Pablo Garrido <[email protected]> * Move 2.7.2 to new ci Signed-off-by: Pablo Garrido <[email protected]> * Deprecate <v2.7 Signed-off-by: Pablo Garrido <[email protected]> * Readme Signed-off-by: Pablo Garrido <[email protected]> (cherry picked from commit 07797df) # Conflicts: # .github/workflows/nightly.yml * Fix Signed-off-by: Pablo Garrido <[email protected]> * Fix Signed-off-by: Pablo Garrido <[email protected]> Co-authored-by: Pablo Garrido <[email protected]>
FYI @pablogs9 @uLipe , we need to change zephyr include paths for https://github.com/zephyrproject-rtos/zephyr/releases/tag/zephyr-v3.1.0:
|
Yes, altough this could be done in other PR, the kconfig option for legacy
includes is only disabled to run apps under twister which is used to do
unit tests for zephyr components.
Le mer. 17 août 2022 à 07:45, Antonio Cuadros ***@***.***> a
écrit :
… FYI @pablogs9 <https://github.com/pablogs9> @uLipe
<https://github.com/uLipe> , we need to change zephyr include paths for
v.3.1.0 and beyond:
https://github.com/zephyrproject-rtos/zephyr/releases/tag/zephyr-v3.1.0:
All Zephyr public headers have been moved to include/zephyr, meaning they
need to be prefixed with <zephyr/...> when included. Because this change
can potentially break many applications or libraries,
:kconfig:option:CONFIG_LEGACY_INCLUDE_PATH is provided to allow using the
old include path. This option is now enabled by default to allow a smooth
transition. In order to facilitate the migration to the new include
prefix, a
script to automate the process is also provided:
:zephyr_file:scripts/utils/migrate_includes.py.
—
Reply to this email directly, view it on GitHub
<#64 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABNWX5OPS7P4U4F7AZ33M3LVZS7D5ANCNFSM54367PPA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Do we have any define in the Zephyr build system indicating the version so we can conditionally include the correct header? |
Signed-off-by: Pablo Garrido [email protected]