Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards: move board specific configurations #63

Merged
merged 5 commits into from
Aug 26, 2022
Merged

boards: move board specific configurations #63

merged 5 commits into from
Aug 26, 2022

Conversation

uLipe
Copy link

@uLipe uLipe commented Jul 26, 2022

Te idea is to keep consistent with other zephyr modules and separate board specific details into their own overlays.

Also add the example l475 IoT discovery board as an example.

No changes in the environment or build.

@uLipe
Copy link
Author

uLipe commented Jul 26, 2022

@pablogs9 @Acuadros95 PTAL.

@pablogs9
Copy link
Member

Running CI, thanks a lot @uLipe

@pablogs9
Copy link
Member

@mergify backport foxy galactic main

@pablogs9 pablogs9 requested review from pablogs9 and Acuadros95 July 27, 2022 06:13
@mergify
Copy link
Contributor

mergify bot commented Jul 27, 2022 •
edited
Loading

backport foxy galactic main

✅ Backports have been created

@pablogs9
Copy link
Member

It seems to break the CI @uLipe : https://github.com/micro-ROS/micro_ros_zephyr_module/runs/7534484810?check_suite_focus=true#step:4:5888

@uLipe
Copy link
Author

uLipe commented Jul 27, 2022

@pablogs9 my bad, during rebase I dropped a piece of the dts I will change this to draft while I fix it

@uLipe uLipe changed the title boards: move board specific configurations draft: boards: move board specific configurations Jul 27, 2022
@uLipe uLipe marked this pull request as draft July 27, 2022 15:20
@uLipe
Copy link
Author

uLipe commented Jul 27, 2022

It seems the problem is more complex, the ucd node was introduced from zephyr version 2.7 , which is on my env for now.

For now I will make this compatible with 2.6 and figure later how to make the things to be compatible across the RTOS versions

@pablogs9
Copy link
Member

Thanks. Maybe we should investigate the working status of this module in 2.7 @Acuadros95

@uLipe uLipe force-pushed the feature/board_specific branch from d06e442 to f5c6986 Compare July 27, 2022 16:13
@uLipe uLipe changed the title draft: boards: move board specific configurations boards: move board specific configurations Jul 27, 2022
@uLipe uLipe marked this pull request as ready for review July 27, 2022 16:13
@uLipe
Copy link
Author

uLipe commented Jul 27, 2022

@pablogs9 PTAL again, for now let's keep compatible with 2.6.

Actually I have this running on Zephyr 3.1 but using the overlay + kconfig updates that broke the CI + this PR ros2/rcutils#368

@pablogs9
Copy link
Member

Could you take a look at this #64 @uLipe. We would like to have this working with v3.1.0 as you have.

@uLipe uLipe mentioned this pull request Jul 28, 2022
Merged
@uLipe uLipe force-pushed the feature/board_specific branch from f5c6986 to 45bfc52 Compare July 28, 2022 15:30
@uLipe
Copy link
Author

uLipe commented Jul 28, 2022

@pablogs9 , @Acuadros95 , I just took the opportunity to modify the zephyr transport serial port to use the DT macros, label property in the devices are being removed from Zephyr and will not work in future kernel releases.

Please take another review and ask me any questions you might to have.

@pablogs9
Copy link
Member

I'll take a look on Monday when I have some hardware in the office

@pablogs9
Copy link
Member

pablogs9 commented Aug 2, 2022

Hello @uLipe:

  • I have been able to test this with serial transport in disco_l475_iot1
  • Not able to build the serial-usb example
  • Should we drop the support for v2.4.0 if we merge this PR?

@uLipe
Copy link
Author

uLipe commented Aug 2, 2022

Hi @pablogs9 my bad, I forgot to push the serial to usb commit to the PR will do it later and you will be able to test.

@uLipe uLipe force-pushed the feature/board_specific branch from 45bfc52 to f1b89c7 Compare August 2, 2022 15:44
@uLipe
Copy link
Author

uLipe commented Aug 2, 2022

@pablogs9 PTAL again, you may able to build serial usb now

@uLipe uLipe requested a review from pablogs9 August 2, 2022 23:54
@uLipe
Copy link
Author

uLipe commented Aug 4, 2022

Hi @pablogs9 any updates regarding your tests?

About the Zephyr version I think it is safe to drop the 2.4 support, since most of V2 users would go to version 2.6 or 2.7, the last one is a LTS version.

There is no Zephyr-API breaking changes across 2.4 to 2.7, the same is not true for the build system for example, depending on what changed in a particular subsystem.

@pablogs9
Copy link
Member

pablogs9 commented Aug 5, 2022

Hello @uLipe, I'll check this on Monday in the office, because I have no boards right now.

Meanwhile, I would like to drop 2.4 and add 2.7 in this PR: #64 is it possible for you to take a look there?

@pablogs9
Copy link
Member

pablogs9 commented Aug 8, 2022

Hello @uLipe, I have been able to build the USB example but I have the following error:

*** Booting Zephyr OS build v2.6.0-rc1  ***
Failed to enable USB

Any idea? I'm working in the disco_l475_iot1

@uLipe
Copy link
Author

uLipe commented Aug 10, 2022

@pablogs9 sure, I will do that late here, and re-request your review.

@uLipe
Copy link
Author

uLipe commented Aug 10, 2022

@pablogs9 btw the error you re receiving is a timeout that is coming from USB endopoint, code 5 is -EIO, which is generated by the CDC ACM class when starting endpoint sending and no notification about the write is read back, are the connections, cable ot host computer okay? Do you see the enumeration on your host?

@uLipe uLipe force-pushed the feature/board_specific branch 2 times, most recently from a26502f to ad2f02b Compare August 10, 2022 18:42
@uLipe
Copy link
Author

uLipe commented Aug 10, 2022

@pablogs9 rebase, please check one more time.

pablogs9
pablogs9 requested changes Aug 11, 2022
View reviewed changes
@uLipe uLipe force-pushed the feature/board_specific branch from ad2f02b to af8165d Compare August 11, 2022 11:14
@uLipe
Copy link
Author

uLipe commented Aug 11, 2022

@pablogs9 fixed the changelog, please do a check again.

pablogs9
pablogs9 reviewed Aug 11, 2022
View reviewed changes
pablogs9
pablogs9 approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@pablogs9 pablogs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @Acuadros95 merge if you are ok

@Acuadros95
Copy link
Contributor

@uLipe Could you take a look at the CI? detail

/__w/micro_ros_zephyr_module/micro_ros_zephyr_module/micro_ros_zephyr_module/boards/disco_l475_iot1.conf:1: warning: attempt to assign the value 'y' to the undefined symbol USB
...

error: Aborting due to Kconfig warnings

@uLipe
Copy link
Author

uLipe commented Aug 25, 2022

@pablogs9 sorry for the delay, since we dropped the version 2.6 the CONFIG_USB symbol was also deprecated, I will remove it and update the PR

boards: disco_l475_iot1: add zephyr UDC0 nodelabel
7266123 
replacing the CONFIG_USB symbol dropped in version 2.6

Signed-off-by: Felipe Neves <[email protected]>
@uLipe uLipe force-pushed the feature/board_specific branch from 15d8ae4 to 7266123 Compare August 25, 2022 22:20
@uLipe
Copy link
Author

uLipe commented Aug 25, 2022

@pablogs9 @Acuadros95 I added the Zephyr UDC0 nodelabel, which replaces the CONFIG_USB from version 2.7 and above, please approve the workflow when you have time.

pablogs9
pablogs9 approved these changes Aug 26, 2022
View reviewed changes
pablogs9
pablogs9 reviewed Aug 26, 2022
View reviewed changes
@pablogs9
Copy link
Member

@Acuadros95 PTAL and merger if you are ok

Acuadros95
Acuadros95 approved these changes Aug 26, 2022
View reviewed changes
Copy link
Contributor

@Acuadros95 Acuadros95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Acuadros95 Acuadros95 merged commit 7e07006 into micro-ROS:humble Aug 26, 2022
mergify bot pushed a commit that referenced this pull request Aug 26, 2022
@mergify
boards: move board specific configurations (#63)
50ce825 
* 4.0.0

* boards: move board specifc details to its own folder

Signed-off-by: Felipe <[email protected]>

* transports: use zephyr DT macros to set the serial
port for serial transport.

Signed-off-by: Felipe <[email protected]>

* boards: disco_l475_iot1: add zephyr UDC0 nodelabel

replacing the CONFIG_USB symbol dropped in version 2.6

Signed-off-by: Felipe Neves <[email protected]>

* Update CHANGELOG.rst

Signed-off-by: Felipe <[email protected]>
Signed-off-by: Felipe Neves <[email protected]>
Co-authored-by: Pablo Garrido <[email protected]>
(cherry picked from commit 7e07006)
@mergify mergify bot mentioned this pull request Aug 26, 2022
Closed
mergify bot pushed a commit that referenced this pull request Aug 26, 2022
@mergify
boards: move board specific configurations (#63)
8580ddb 
* 4.0.0

* boards: move board specifc details to its own folder

Signed-off-by: Felipe <[email protected]>

* transports: use zephyr DT macros to set the serial
port for serial transport.

Signed-off-by: Felipe <[email protected]>

* boards: disco_l475_iot1: add zephyr UDC0 nodelabel

replacing the CONFIG_USB symbol dropped in version 2.6

Signed-off-by: Felipe Neves <[email protected]>

* Update CHANGELOG.rst

Signed-off-by: Felipe <[email protected]>
Signed-off-by: Felipe Neves <[email protected]>
Co-authored-by: Pablo Garrido <[email protected]>
(cherry picked from commit 7e07006)
This was referenced Aug 26, 2022
Closed
Open
mergify bot pushed a commit that referenced this pull request Aug 26, 2022
@mergify
boards: move board specific configurations (#63)
fdf14ba 
* 4.0.0

* boards: move board specifc details to its own folder

Signed-off-by: Felipe <[email protected]>

* transports: use zephyr DT macros to set the serial
port for serial transport.

Signed-off-by: Felipe <[email protected]>

* boards: disco_l475_iot1: add zephyr UDC0 nodelabel

replacing the CONFIG_USB symbol dropped in version 2.6

Signed-off-by: Felipe Neves <[email protected]>

* Update CHANGELOG.rst

Signed-off-by: Felipe <[email protected]>
Signed-off-by: Felipe Neves <[email protected]>
Co-authored-by: Pablo Garrido <[email protected]>
(cherry picked from commit 7e07006)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogs9 pablogs9 pablogs9 approved these changes

@Acuadros95 Acuadros95 Acuadros95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uLipe @pablogs9 @Acuadros95