Fix #294 & go travis tests #310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6e5da12.
Fixed #294 by the prior revert of 6e5da12. Fixed the broken golang tests by: * Added explicit path to header files and lib * Set the LCM backend queue size to 0 to prevent message drops (as we are handling buffering, potential drops & drop count) * Enabled verification of ordering of messages in the golang unit tests * Wrapped lcm_handle() with a select as it was reading on invalid handle after destroy() is called. Enable build of golang backend and set required go version to 1.10, might work with older versions but Travis fails and its untested.
gustafj
force-pushed
the
fix-294-golang-backend
branch
from
d4e0a48 to
724a9f2
Compare
This was referenced Feb 11, 2020
Closed
|
@gustafj we are digging the project out of the backlog of old PRs currently. Is this something you are interested in merging still? If so, would you be available to rebase it on the latest master? We don't have the bandwidth to maintain the go target currently, so we may end up deprecating it unless someone is interested in keeping it updated. |
|
Closing this PR to inactivity, but feel free to reopen if you're interested in picking it back up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #294 by the prior revert of 6e5da12.
Fixed the broken golang tests by:
are handling buffering, potential drops & drop count)
handle after destroy() is called.
Enable build of golang backend and set required go version to 1.10,
might work with older versions but Travis fails and its untested.