Go emit error #306
Go emit error #306
Conversation
* Add check if: - fingerprint suffix is requested, and - member is primitive type If not, don't bother calling lcm_find_struct() when creating array
|
Go tests failing due to <lcm/lcm.h> not found |
|
I will not merge this as I'd rather revert the broken commit/PR #288 (that should not have been merged, my bad) that introduced the issue, see #310. And why do you ignore the fingerprint for primitive types? Seems wrong to me. Thanks for the work! |
|
I'm on my phone atm, but if I've managed to get a correct overview while browsing the code, the fingerprint calculated in emit_go_array_loops() is only used for appending to the type name. As per the comment above go_typename() (i.e. "Fingerprint suffix is added if fingerprint is != 0"), I think the rationale was to avoid adding the suffix to primitive types. However, that is already achieved in go_typename(), so the check for a primitive type is redundant and confusing. Anyway, I'd go with a different, more robust solution if I were to implement it again, so I'll close this PR. Thanks :) |
Resolving issue #294 and re-enabling go in CMakeLists.txt
Cause:
lcm_find_struct() returns null for primitive types.
Solution:
Only invoke if non-primitive type.