Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark C# and Go and as Unmaintained #423

Merged
merged 3 commits into from
Apr 6, 2023

Conversation

nosracd
Copy link
Contributor

@nosracd nosracd commented Mar 15, 2023

More official notice for this comment.

@nosracd nosracd requested a review from kyonifer March 15, 2023 20:49
@tprk77
Copy link
Member

tprk77 commented Mar 16, 2023

So before you go ahead and deprecate these bindings, I think you should state why they are being deprecated. I see the linked comment for the Go binding, but no information on the C# binding. Also, I'm not sure if you're aware of this but LCM does have two (mostly inactive) mailing lists:

I think you should notify these lists before you start deleting code. It might also be useful to ask these lists if anyone is actually using these bindings, and if anyone is willing to maintain them.

Anyway, I am not really familiar with the C# binding, but I think it would be kind of a shame to get rid of it because it's been around since before 2009. I think it might make more sense to say "use at your own risk" and keep it archived in place. Then again, maybe that's what you mean by deprecation.

@tprk77
Copy link
Member

tprk77 commented Mar 16, 2023

Link: #370

@kyonifer
Copy link
Contributor

I think it might make more sense to say "use at your own risk" and keep it archived in place. Then again, maybe that's what you mean by deprecation.

Yep, that is what we meant to say. Perhaps it would be more accurate to mark it "unmaintained" instead of "deprecated". There's no plan to remove any code from the tree at this point. But we thought it would be prudent to note somewhere that there is currently no maintainer for those targets. The hope is that such a note might get an interested party to step in and sign up to maintain them.

If it becomes clear at some point in the future that those targets are broken on modern systems and nobody has offered to fix them, it might make sense to pull them from the tree to not mislead people. But that isn't the situation yet.

So before you go ahead and deprecate these bindings, I think you should state why they are being deprecated.

If we note them as unmaintained instead that will hopefully be self-explanatory. Essentially "use at your own risk".

Also, I'm not sure if you're aware of this but LCM does have two (mostly inactive) mailing lists:
I think you should notify these lists before you start deleting code. It might also be useful to ask these lists if anyone is actually using these bindings, and if anyone is willing to maintain them.

Thanks for the suggestion. We are aware of them, but planning to do most of the active development going forward on github. Making an announcement of that fact on the lists is a good idea though, as well as asking if there is any interest in maintaining those targets. We will do so.

@nosracd nosracd force-pushed the dev-release-1.5 branch 2 times, most recently from 2698e4f to 9cfbccf Compare March 16, 2023 16:24
@nosracd nosracd force-pushed the deprecate/csharp_go branch from 8a167f0 to 76c7ef2 Compare March 16, 2023 20:15
@nosracd nosracd changed the title Deprecate C# and Go Mark C# and Go and Unmaintained Mar 16, 2023
@nosracd nosracd changed the title Mark C# and Go and Unmaintained Mark C# and Go and as Unmaintained Mar 16, 2023
@nosracd nosracd force-pushed the deprecate/csharp_go branch from 76c7ef2 to 3b576c9 Compare March 16, 2023 20:17
@nosracd
Copy link
Contributor Author

nosracd commented Mar 16, 2023

I've updated the phrasing to make it more clear that we're not planning on dropping these languages but no one has yet volunteered to keep them up.

@tprk77
Copy link
Member

tprk77 commented Mar 17, 2023

For what it's worth I appreciate the change in wording!

The mailing lists are admittedly old-school. But LCM is an old project too. I think announcement about the project's future and what you're planning would make sense, if only to notify the project's "alumni." (Some of which might even be pre-GitHub.)

@kyonifer
Copy link
Contributor

I think announcement about the project's future and what you're planning would make sense, if only to notify the project's "alumni." (Some of which might even be pre-GitHub.)

Agreed. I made a post earlier today along those lines, hopefully doing just that.

@ihilt ihilt changed the base branch from dev-release-1.5 to master April 5, 2023 14:55
@nosracd nosracd requested review from ihilt and removed request for kyonifer April 5, 2023 18:36
@ihilt ihilt merged commit ab70eaf into lcm-proj:master Apr 6, 2023
@ihilt ihilt deleted the deprecate/csharp_go branch April 6, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants