Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added G36 official release control #3120

Merged
merged 287 commits into from
Oct 6, 2022
Merged

Added G36 official release control #3120

merged 287 commits into from
Oct 6, 2022

Conversation

JayHuLBL
Copy link
Contributor

This closes #1913.

@mwetter
Copy link
Member

mwetter commented Sep 30, 2022

@JayHuLBL : Can you please address the following items below. Then it is ready to merge if all tests pass. Glad to have this finally on the master branch.

  • Correct the following hyperlinks (regenerate the html output in Dymola to make sure all hyperlinks are correct):
Error: Can not resolve link "modelica://Buildings.Controls.OBC.ASHRAE.G36_PR1.AHUs.MultiZone.VAV.Controller" in [Buildings.UsersGuide.Conventions](modelica://Buildings.UsersGuide.Conventions)
Error: Can not resolve link "modelica://Buildings.Controls.OBC.ASHRAE.G36_PR1.TerminalUnits.Controller" in [Buildings.UsersGuide.Conventions](modelica://Buildings.UsersGuide.Conventions)
Error: Can not resolve link "modelica://Buildings.Controls.OBC.ASHRAE.G36_PR1.AHUs.MultiZone.VAV.SetPoints.SupplyTemperature" in [Buildings.UsersGuide.Conventions](modelica://Buildings.UsersGuide.Conventions)
Error: Can not resolve link "modelica://Buildings.Controls.OBC.ASHRAE.G36_PR1.AHUs.SingleZone.VAV.Controller" in [Buildings.Obsolete.Air.Systems.SingleZone.VAV.Examples.OptimalStart](modelica://Buildings.Obsolete.Air.Systems.SingleZone.VAV.Examples.OptimalStart)
Error: Can not resolve link "modelica://Buildings.Controls.OBC.ASHRAE.G36_PR1.AHUs.SingleZone.VAV.Controller" in [Buildings.Obsolete.Air.Systems.SingleZone.VAV.Examples.OptimalStart.Guideline36Spring](modelica://Buildings.Obsolete.Air.Systems.SingleZone.VAV.Examples.OptimalStart.Guideline36Spring)
Error: Can not resolve link "modelica://Buildings.Controls.OBC.ASHRAE.G36_PR1.AHUs.SingleZone.VAV.Controller" in [Buildings.Obsolete.Air.Systems.SingleZone.VAV.Examples.OptimalStart.Guideline36Summer](modelica://Buildings.Obsolete.Air.Systems.SingleZone.VAV.Examples.OptimalStart.Guideline36Summer)
Error: Can not resolve link "modelica://Buildings.Controls.OBC.ASHRAE.G36_PR1.AHUs.SingleZone.VAV.Controller" in [Buildings.Obsolete.Air.Systems.SingleZone.VAV.Examples.OptimalStart.Guideline36Winter](modelica://Buildings.Obsolete.Air.Systems.SingleZone.VAV.Examples.OptimalStart.Guideline36Winter)
Error: Can not resolve link "modelica://Buildings.Controls.OBC.ASHRAE.G36_PR1.AHUs.SingleZone.VAV.Controller" in [Buildings.Obsolete.Air.Systems.SingleZone.VAV.Examples.OptimalStart.BaseClasses.ZoneWithAHUG36](modelica://Buildings.Obsolete.Air.Systems.SingleZone.VAV.Examples.OptimalStart.BaseClasses.ZoneWithAHUG36)
Error: Can not resolve link "modelica://Buildings.Controls.OBC.ASHRAE.G36_PR1" in [Buildings.Obsolete.Examples.VAVReheat.Guideline36](modelica://Buildings.Obsolete.Examples.VAVReheat.Guideline36)
Error: Can not resolve link "modelica://Buildings.Controls.OBC.ASHRAE.G36_PR1" in [Buildings.Obsolete.Examples.VAVReheat.BaseClasses.Guideline36](modelica://Buildings.Obsolete.Examples.VAVReheat.BaseClasses.Guideline36)

@mwetter mwetter merged commit 7a10d6b into master Oct 6, 2022
@mwetter mwetter deleted the issue1913_g36_final branch October 6, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update G36 sequences based on the official release version
3 participants