Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added G36 official release control #3120

Merged
merged 287 commits into from
Oct 6, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
287 commits
Select commit Hold shift + click to select a range
7dc5086
updating single zone VAV sequences
JayHuLBL Oct 1, 2020
f131bd0
deleted zone status sequence in single zone AHU control [ci skip]
JayHuLBL Oct 14, 2020
3a8b6b7
Merge branch 'master' into issue1913_g36_final
JayHuLBL Dec 7, 2020
24e241a
limited CI test to DHC package
JayHuLBL Dec 8, 2020
f33fdf3
Merge branch 'master' into issue1913_g36_final
JayHuLBL Dec 8, 2020
f65e657
updating the single zone AHU controller
JayHuLBL Dec 8, 2020
c70cbfc
updated single zone VAV ahu controller
JayHuLBL Dec 9, 2020
503269d
updated single zone VAV controller documents
JayHuLBL Dec 10, 2020
b9c4fce
created sequence to generate position limit of economizer with separa…
JayHuLBL Dec 10, 2020
0e79f09
created sequence to find the position limits of the economizer damper…
JayHuLBL Dec 10, 2020
b68a696
restructured economizer subsequence package
JayHuLBL Dec 10, 2020
6ca4097
created sequences for modulate dampers of economizer with return fan …
JayHuLBL Dec 11, 2020
d396336
updating economizer controller
JayHuLBL Dec 11, 2020
8114e33
cleaning up economizer control
JayHuLBL Dec 13, 2020
e7db543
cleaning up multizone AHU controller
JayHuLBL Dec 14, 2020
f8f10b0
merged master #1913 [ci skip]
JayHuLBL Mar 26, 2021
d875e47
Merge branch 'master' into issue1913_g36_final
JayHuLBL May 25, 2021
ea1eada
added relief damper [ci skip]
JayHuLBL May 26, 2021
91a81a0
updated return fan control with airflow tracking
JayHuLBL May 27, 2021
6a2c3da
added documentation
JayHuLBL May 27, 2021
af899d8
removed obsolete sequences
JayHuLBL May 28, 2021
d266e4e
Merge branch 'master' into issue1913_g36_final
JayHuLBL Jun 8, 2021
b6a4d90
Merge branch 'master' into issue1913_g36_final
JayHuLBL Jul 30, 2021
693d89a
added relief fan control [ci skip]
JayHuLBL Aug 10, 2021
83fa019
Merge branch 'master' into issue1913_g36_final
JayHuLBL Aug 10, 2021
59653b3
clean up the economizer subsequence package [ci skip]
JayHuLBL Aug 10, 2021
1e96244
created freeze protection sequence [ci skip]
JayHuLBL Aug 13, 2021
44b2a1b
Merge branch 'master' into issue1913_g36_final
JayHuLBL Jan 5, 2022
41f4c1b
merged master changes [ci skip]
JayHuLBL Jan 5, 2022
a2fb51c
created plant request sequence [ci skip]
JayHuLBL Jan 7, 2022
7475091
updating multizone AHU controller
JayHuLBL Jan 7, 2022
2f10684
updating supply temperature setpoint control for multizone AHU, due t…
JayHuLBL Jan 7, 2022
3769e7e
updating multizone AHU controller [ci skip]
JayHuLBL Jan 10, 2022
5390d19
Merge branch 'master' into issue1913_g36_final
JayHuLBL Jan 11, 2022
8302242
added connector names [ci skip]
JayHuLBL Jan 11, 2022
d857059
updated multizone AHU controller [ci skip]
JayHuLBL Jan 13, 2022
f1b1230
Merge branch 'master' into issue1913_g36_final
JayHuLBL Jan 13, 2022
4290aef
added pressure control sequences to multizone AHU controller [ci skip]
JayHuLBL Jan 13, 2022
6e0f9b2
updating single zone AHU controller [ci skip]
JayHuLBL Jan 19, 2022
ac390c0
updating single zone AHU controller [ci skip]
JayHuLBL Jan 19, 2022
c1f02e7
updated single zone AHU controller Icon layer [ci skip]
JayHuLBL Jan 19, 2022
50b2dc9
renamed class [ci skip]
JayHuLBL Jan 19, 2022
69768d3
updated single AHU controller documentation [ci skip]
JayHuLBL Jan 19, 2022
1eb188c
Merge branch 'master' into issue1913_g36_final
JayHuLBL Jan 20, 2022
d3c5e67
composing cooling only box controller [ci skip]
JayHuLBL Jan 20, 2022
f30d94a
Merge branch 'master' into issue1913_g36_final
JayHuLBL Jan 26, 2022
5b4efa6
Merge branch 'master' into issue1913_g36_final
JayHuLBL Feb 2, 2022
1f44c89
finished editing cooling only box controller
JayHuLBL Feb 2, 2022
96ff8d0
changed default names
JayHuLBL Feb 2, 2022
6ad6a3f
updated parallel fan unit alarms
JayHuLBL Feb 3, 2022
b857f84
Merge branch 'master' into issue1913_g36_final
JayHuLBL Feb 4, 2022
6d02608
updated CDL blocks name
JayHuLBL Feb 4, 2022
3fe1c04
updated add blocks
JayHuLBL Feb 4, 2022
6ef16c4
updating parallel fan powered unit controller
JayHuLBL Feb 5, 2022
5d1c7d9
updated constant valume fan powered unit controller
JayHuLBL Feb 7, 2022
f3f8217
updating variable volume parallel fan powered terminal unit controller
JayHuLBL Feb 8, 2022
911789e
Merge branch 'master' into issue1913_g36_final
JayHuLBL Feb 8, 2022
07a43fd
merged master and updated CDL blocks
JayHuLBL Feb 8, 2022
184cd21
corrected overlaping connector
JayHuLBL Feb 8, 2022
f50965e
updated damper valve control for paralle fan-powered unit with variab…
JayHuLBL Feb 9, 2022
bd3f694
updated controller of parallel fan-powered terminal unit with variabl…
JayHuLBL Feb 9, 2022
3f2173e
updated subsequences for controlling constant-volume series fan-power…
JayHuLBL Feb 9, 2022
42e7523
updated controller for constant-volume series fan-powered terminal unit
JayHuLBL Feb 9, 2022
a5c41cc
updated controller for variable-volume series fan-powered terminal unit
JayHuLBL Feb 10, 2022
ce1b4f8
differentiated terminal fan and AHU supply fan
JayHuLBL Feb 10, 2022
d40d309
updated snap acting controlled dual-duct terminal unit dampers control
JayHuLBL Feb 11, 2022
586bf6b
updated controller for dual duct terminal unit with snap acting control
JayHuLBL Feb 15, 2022
550c824
Merge branch 'master' into issue1913_g36_final
JayHuLBL Feb 15, 2022
ad75682
updating mixing controlled dual-duct unit
JayHuLBL Feb 15, 2022
5eaa692
updated damper control
JayHuLBL Feb 15, 2022
09b3f71
updated controller for dual duct terminal unit using mixing control w…
JayHuLBL Feb 16, 2022
8ee6dbe
updating dual-duct unit using mixing control with discharge flow sensor
JayHuLBL Feb 16, 2022
50a471b
updated subsequences for dual-duct mixing control with discharge flow…
JayHuLBL Feb 16, 2022
dcc7a43
updated controller for dual-duct mixing control with discharge flow s…
JayHuLBL Feb 17, 2022
04b0275
updated controller for the dual-duct unit with cold-duct minimum control
JayHuLBL Feb 17, 2022
d89edcc
created validation model for time suppression sequence
JayHuLBL Feb 17, 2022
dc67852
created script
JayHuLBL Feb 17, 2022
c9bf504
created validation model for classes in thermal zone package
JayHuLBL Feb 18, 2022
c20514d
Merge branch 'master' into issue1913_g36_final
JayHuLBL Feb 24, 2022
18585e0
Merge branch 'master' into issue1913_g36_final
JayHuLBL Feb 25, 2022
3057d6f
creating validation model
JayHuLBL Feb 26, 2022
6269e37
creating validation models
JayHuLBL Feb 28, 2022
05e11ab
creating validation models
JayHuLBL Mar 2, 2022
a42e6a1
added validation models for the multizone AHU economizer control sequ…
JayHuLBL Mar 3, 2022
a716d4a
adding validation models for multizone VAV setpoints package
JayHuLBL Mar 3, 2022
1d106d3
improving relief fan control
JayHuLBL Mar 8, 2022
13d55a3
added validation models for multizone AHU setpoint sequences
JayHuLBL Mar 8, 2022
f4a2ebc
renamed model
JayHuLBL Mar 8, 2022
44d36c4
added validation models for single zone economizers
JayHuLBL Mar 10, 2022
8e3ae28
adding validation models for single zone AHU setpoint sequences
JayHuLBL Mar 10, 2022
b79660f
created validation models for single zone AHU controller
JayHuLBL Mar 11, 2022
7c006f6
added hot water coil flag to the reheat unit controller
JayHuLBL Mar 11, 2022
6a4894d
adding validation models for cooling only unit
JayHuLBL Mar 11, 2022
fd2dc9c
created subsequences for cooling unit control
JayHuLBL Mar 11, 2022
33be1ac
added cooling only unit controller validation model
JayHuLBL Mar 11, 2022
03af89a
Merge branch 'master' into issue1913_g36_final
JayHuLBL Mar 11, 2022
79dad11
adding validation models for dual-duct units
JayHuLBL Mar 14, 2022
fb3ebac
created validation model for dual-duct unit with the minimum cold-duc…
JayHuLBL Mar 15, 2022
50a90ce
added validation models for dual duct unit using mixing control with …
JayHuLBL Mar 15, 2022
7f7372b
added validation models for dual duct unit using mixing control with …
JayHuLBL Mar 15, 2022
b1316b8
adding validation models for dual-duct unit with snap acting control
JayHuLBL Mar 16, 2022
feb172b
adding validation models for dual duct unit with snap acting control
JayHuLBL Mar 16, 2022
6a3922b
added validation models for parallel fan powered unit with constant v…
JayHuLBL Mar 16, 2022
7096a26
added validation models for parallel-fan powered unit with variable v…
JayHuLBL Mar 16, 2022
fa6bfb5
Merge branch 'master' into issue1913_g36_final
JayHuLBL Mar 17, 2022
1510047
added hot water coil to parallel-fan powered unit controllers
JayHuLBL Mar 17, 2022
aa62631
changed single package mo file to being a folder
JayHuLBL Mar 17, 2022
3ece51e
added validation models for series fan powered unit controllers
JayHuLBL Mar 17, 2022
58db8d5
refactored package order
JayHuLBL Mar 17, 2022
69adbcd
added validation models for reheat unit controller
JayHuLBL Mar 17, 2022
84f97c7
addressing comments
JayHuLBL Mar 21, 2022
efbac56
changing CO2 setpoint as input
JayHuLBL Mar 21, 2022
fd4ade1
changed the CO2 concentration setpoint to be an input
JayHuLBL Mar 22, 2022
80444a9
added economizer high limit cut off calculation
JayHuLBL Mar 24, 2022
679f566
added title 24 ventilation setpoint calculaiton
JayHuLBL Mar 28, 2022
9594bc9
Merge branch 'master' into issue1913_g36_final
JayHuLBL Mar 28, 2022
34fb2eb
added title 24 ventilation setting to single zone AHU control
JayHuLBL Mar 29, 2022
26acea4
added in Title 24 ventilation setpoint option in the terminal unit co…
JayHuLBL Mar 30, 2022
4405be1
modifying minimum outdoor air setpoint calculation for MZVAV
JayHuLBL Mar 31, 2022
54871ea
added title 24 options to MZVAV subsequences
JayHuLBL Apr 1, 2022
2625a3b
updated validation model
JayHuLBL Apr 4, 2022
778c300
Merge branch 'master' into issue1913_g36_final
JayHuLBL Apr 4, 2022
4849514
added title 24 option and the economizer high limit calculation in tM…
JayHuLBL Apr 6, 2022
a6d3bc3
updated zone group calculation
JayHuLBL Apr 7, 2022
d199b38
refactored package order
JayHuLBL Apr 7, 2022
32e124c
added on-off minimum outdoor air damper output
JayHuLBL Apr 8, 2022
a0c7bdb
Merge branch 'master' into issue1913_g36_final
JayHuLBL Apr 11, 2022
9ae91a4
refactoring naming
JayHuLBL Apr 11, 2022
1481301
updating freeze stat connector
JayHuLBL Apr 12, 2022
ba38b2d
Merge branch 'master' into issue1913_g36_final
JayHuLBL Apr 13, 2022
5c3fe15
updated freeze stat status input
JayHuLBL Apr 13, 2022
3355d49
updating the namings of the connector and parameters
JayHuLBL Apr 18, 2022
835be1c
Merge branch 'master' into issue1913_g36_final
JayHuLBL Apr 18, 2022
8ebc2c9
updated namings for MZVAV controller
JayHuLBL Apr 18, 2022
11f551e
corrected namings in AHU controllers
JayHuLBL Apr 19, 2022
25e0da1
updated namings in cooling only unit
JayHuLBL Apr 19, 2022
70d8854
corrected namings used in terminal unit controllers
JayHuLBL Apr 20, 2022
ac2f494
added fixed plus differential dry bulb high limit cut option
JayHuLBL Apr 21, 2022
c28f578
changed exhaust damper to relief damper
JayHuLBL Apr 22, 2022
05d1524
renamed connecter
JayHuLBL Apr 25, 2022
5828039
added barometric relief option
JayHuLBL Apr 27, 2022
ee0b626
Merge branch 'master' into issue1913_g36_final
JayHuLBL Apr 27, 2022
99d0c04
unified the parameter namings, updated comments
JayHuLBL Apr 28, 2022
852f150
propageted min and max return fan speed
JayHuLBL Apr 29, 2022
a117ac8
added default value to hysteresis parameters
JayHuLBL May 5, 2022
9577bf4
added flow setpoint override to damper (valve) control subsequence
JayHuLBL May 6, 2022
91236cc
avoid re-define of the nominal flow
JayHuLBL May 6, 2022
1ef9277
revised comments
JayHuLBL May 6, 2022
7fea0e5
run unit tests
JayHuLBL May 10, 2022
51e6b6c
Merge branch 'master' into issue1913_g36_final
JayHuLBL May 10, 2022
b6c95ea
updating the closed loop model
JayHuLBL May 11, 2022
37be0bc
Merge branch 'master' into issue1913_g36_final
JayHuLBL May 26, 2022
96ff588
unified parameter namings
JayHuLBL May 31, 2022
51edf75
corrected link
JayHuLBL May 31, 2022
ba6ce75
added connector attributes
JayHuLBL May 31, 2022
a11719a
exported terminal box actual valve position
JayHuLBL May 31, 2022
34fc7bc
output ventilation setpoints
JayHuLBL May 31, 2022
abdb0f3
updating parating for the closed loop model
JayHuLBL May 31, 2022
7ba8ba7
merged master
JayHuLBL May 31, 2022
159c54c
reverted changes
JayHuLBL Jun 1, 2022
6b067c0
corrected typos
JayHuLBL Jun 1, 2022
54b16b8
updated parameter comments
JayHuLBL Jun 1, 2022
52c1acd
added closed-loop model
JayHuLBL Jun 1, 2022
48cdf2f
removed redundant connection
JayHuLBL Jun 1, 2022
0ea28c0
added connector conditions
JayHuLBL Jun 1, 2022
2c863b3
setted up the closed-loop model
JayHuLBL Jun 1, 2022
93924c5
Merge branch 'master' into issue1913_g36_final
JayHuLBL Jun 1, 2022
97205f3
added connector condition
JayHuLBL Jun 1, 2022
027fc88
improved zero flow check
JayHuLBL Jun 2, 2022
8b91502
updating figures in documentation
JayHuLBL Jun 6, 2022
2cbda99
updated all figures
JayHuLBL Jun 6, 2022
d34bf48
avoid divide zero
JayHuLBL Jun 16, 2022
f857d68
added missing hys
JayHuLBL Jun 16, 2022
5817629
removed moving mean
JayHuLBL Jun 16, 2022
4a574d0
improved default PID factors
JayHuLBL Jun 16, 2022
7eb9324
added input samplers
JayHuLBL Jun 16, 2022
9436a2f
moved old G36 example to obsolete
JayHuLBL Jun 16, 2022
6d2d5ff
unified control loop hys, added samplers
JayHuLBL Jun 16, 2022
e9ccb07
added true hold to avoid frequent switch
JayHuLBL Jun 17, 2022
77ffb10
corrected invalid text
JayHuLBL Jun 21, 2022
673adce
Merge branch 'master' into issue1913_g36_final
JayHuLBL Jun 22, 2022
a354365
moving G36_PR1 to obsolete package
JayHuLBL Jun 23, 2022
abd0eac
correcting scripts
JayHuLBL Jun 23, 2022
8ec4915
renamed scripts and reference results
JayHuLBL Jun 23, 2022
19e85c4
corrected script paths
JayHuLBL Jun 23, 2022
a1b3eec
removing or updating the usage of the G36_PR1 sequences
JayHuLBL Jun 23, 2022
dd4426d
updating the usage of G36_PR1 sequences
JayHuLBL Jun 23, 2022
0727b52
refactored package orer
JayHuLBL Jun 23, 2022
3d6f570
replaced single zone AHU control sequences
JayHuLBL Jun 24, 2022
8c5cc97
updated reference with Dymola 2022x
JayHuLBL Jun 24, 2022
11596f5
rerun unit test for the VAVReheat models
JayHuLBL Jun 24, 2022
e795f1b
removed G36_PR1 pacakage
JayHuLBL Jun 24, 2022
fafb6fd
removed G36_PR1 pacakage
JayHuLBL Jun 24, 2022
ec2b94f
moved imges and corrected G36_PR1 related links
JayHuLBL Jun 24, 2022
4d03688
changed stop time of the plotter example model
JayHuLBL Jul 5, 2022
e8bed6c
updated reference result
JayHuLBL Jul 5, 2022
b9d0d9d
added conversion script, updated release note
JayHuLBL Jul 5, 2022
ffbf1aa
Merge branch 'master' into issue1913_g36_final
JayHuLBL Jul 20, 2022
26b0f94
merged master
JayHuLBL Aug 9, 2022
8ba70c7
Merge branch 'master' into issue1913_g36_final
JayHuLBL Aug 16, 2022
d199bd9
changed freeze stat enumerations
JayHuLBL Aug 22, 2022
1eff463
merged master
JayHuLBL Aug 23, 2022
3cbe566
separated ahu mode calculation
JayHuLBL Aug 24, 2022
0a22596
addressing comments
JayHuLBL Aug 24, 2022
7465777
addressing multizone AHU controller comments
JayHuLBL Aug 25, 2022
7be670f
improved parameter namings
JayHuLBL Aug 31, 2022
2d7e632
removed zero default value
JayHuLBL Aug 31, 2022
aa25805
removed the damper and valve actual position connectors
JayHuLBL Sep 1, 2022
c153168
updated comments, changed boolean connector name
JayHuLBL Sep 1, 2022
2bff124
changed file name
JayHuLBL Sep 1, 2022
3b292f8
fixed broken links
JayHuLBL Sep 1, 2022
7f8ee62
fixed typos
JayHuLBL Sep 2, 2022
254a9f5
removed colon mark
JayHuLBL Sep 2, 2022
ba7cba2
Merge branch 'master' into issue1913_g36_final
JayHuLBL Sep 6, 2022
b9e34aa
addressed comments
JayHuLBL Sep 6, 2022
de6cf98
corrected the p/dp namings #1913
JayHuLBL Sep 7, 2022
1e11f5a
improved handling of dividing by zero
JayHuLBL Sep 13, 2022
dac3f06
avoided using minimum outdoor air damper status input for return fan …
JayHuLBL Sep 16, 2022
bbefc72
renamed relief fans to fans group
JayHuLBL Sep 16, 2022
c67e939
created single relief fan control
JayHuLBL Sep 20, 2022
2662242
composed relief fan control to multizone AHU controller
JayHuLBL Sep 22, 2022
24ea334
composed the relief fan control to single zone AHU controller
JayHuLBL Sep 27, 2022
72e4539
merged master
JayHuLBL Sep 27, 2022
859cc62
added default values, added reference results of the relief fan control
JayHuLBL Sep 27, 2022
7ccf988
removed BOM
JayHuLBL Sep 27, 2022
65fd011
deleted obsolete OpenModelica script
JayHuLBL Sep 27, 2022
3517f4a
added missing comments
JayHuLBL Sep 28, 2022
2f4b3af
removed self connection
JayHuLBL Sep 28, 2022
02cf18d
changed the time constant value of temperature sensors
JayHuLBL Sep 28, 2022
f879298
corrected variables in mos scripts
JayHuLBL Sep 29, 2022
f1ab9fd
updated reference results
JayHuLBL Sep 29, 2022
bda11e9
added missing comment
JayHuLBL Sep 29, 2022
b427e2d
added missing fill() function
JayHuLBL Sep 29, 2022
203f013
updated reference results in plotter examples package
JayHuLBL Sep 29, 2022
d550924
corrected obsolete models, updated reference results
JayHuLBL Sep 29, 2022
a4e061b
updated reference results
JayHuLBL Sep 29, 2022
5647448
Merge branch 'master' into issue1913_g36_final
mwetter Sep 30, 2022
e5fa731
Added failing new models in Obsolete package to exclusion list
mwetter Sep 30, 2022
94b7d69
Removed non-existent models from configuration file
mwetter Sep 30, 2022
34e11be
Corrected reference of G36
mwetter Sep 30, 2022
6afdfd8
Corrected access to non-existent type
mwetter Sep 30, 2022
b030bce
Corrected access to non-existent type
mwetter Sep 30, 2022
1984a75
corrected hyperlinks
JayHuLBL Oct 3, 2022
7519ef7
reverted the change of temperature sensor time constants
JayHuLBL Oct 3, 2022
35217ee
merged master
JayHuLBL Oct 4, 2022
fda6ead
corrected loop issue
JayHuLBL Oct 5, 2022
0d3680d
updated reference results
JayHuLBL Oct 5, 2022
8818ac5
removed BOM
JayHuLBL Oct 5, 2022
d56529b
updated reference results
JayHuLBL Oct 5, 2022
65156f1
updated reference results of VAV reheat example models in Obsolete pa…
JayHuLBL Oct 5, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
80 changes: 44 additions & 36 deletions Buildings/Air/Systems/SingleZone/VAV/ChillerDXHeatingEconomizer.mo
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ model ChillerDXHeatingEconomizer
parameter Modelica.Units.SI.Power QCoo_flow_nominal(max=0)
"Design capacity of cooling coil"
annotation (Dialog(group="Cooling design"));
parameter Modelica.Units.SI.PressureDifference dp_nominal(displayUnit="Pa")
= 500 "Design pressure drop of flow leg with fan"
parameter Modelica.Units.SI.PressureDifference dp_nominal(displayUnit="Pa")=
500 "Design pressure drop of flow leg with fan"
annotation (Dialog(group="Air design"));
final parameter Modelica.Units.SI.MassFlowRate mChiEva_flow_nominal=-
QCoo_flow_nominal/Buildings.Utilities.Psychrometrics.Constants.cpWatLiq/4
Expand Down Expand Up @@ -68,32 +68,32 @@ model ChillerDXHeatingEconomizer
iconTransformation(extent={{192,-30},{212,-10}})));
Modelica.Blocks.Interfaces.RealOutput PFan(final unit="W")
"Electrical power consumed by the supply fan"
annotation (Placement(transformation(extent={{202,150},{222,170}}),
iconTransformation(extent={{202,150},{222,170}})));
annotation (Placement(transformation(extent={{200,140},{220,160}}),
iconTransformation(extent={{200,140},{220,160}})));
Modelica.Blocks.Interfaces.RealOutput QHea_flow(final unit="W")
"Electrical power consumed by the heating equipment" annotation (Placement(
transformation(extent={{202,130},{222,150}}), iconTransformation(extent={{202,130},
{222,150}})));
transformation(extent={{200,120},{220,140}}), iconTransformation(extent={{200,120},
{220,140}})));
Modelica.Blocks.Interfaces.RealOutput PCoo(final unit="W")
"Electrical power consumed by the cooling equipment" annotation (Placement(
transformation(extent={{202,110},{222,130}}),iconTransformation(extent={{202,110},
{222,130}})));
transformation(extent={{200,100},{220,120}}),iconTransformation(extent={{200,100},
{220,120}})));
Modelica.Blocks.Interfaces.RealOutput PPum(final unit="W")
"Electrical power consumed by the pumps"
annotation (Placement(transformation(extent={{202,90},{222,110}}),
iconTransformation(extent={{202,90},{222,110}})));
annotation (Placement(transformation(extent={{200,80},{220,100}}),
iconTransformation(extent={{200,80},{220,100}})));
Modelica.Blocks.Interfaces.RealOutput TMix(
final unit="K",
displayUnit="degC",
final quantity="ThermodynamicTemperature")
"Mixed air temperature" annotation (Placement(transformation(extent={{202,-70},
{222,-50}}), iconTransformation(extent={{202,-70},{222,-50}})));
"Mixed air temperature" annotation (Placement(transformation(extent={{200,-70},
{220,-50}}), iconTransformation(extent={{202,-70},{222,-50}})));
Modelica.Blocks.Interfaces.RealOutput TSup(
final unit="K",
displayUnit="degC",
final quantity="ThermodynamicTemperature")
"Supply air temperature after coils"
annotation (Placement(transformation(extent={{202,-110},{222,-90}}),
annotation (Placement(transformation(extent={{200,-110},{220,-90}}),
iconTransformation(extent={{202,-110},{222,-90}})));

Buildings.BoundaryConditions.WeatherData.Bus weaBus
Expand Down Expand Up @@ -130,7 +130,7 @@ model ChillerDXHeatingEconomizer
final use_inputFilter=false,
redeclare package Medium = MediumA)
"Supply fan"
annotation (Placement(transformation(extent={{-30,30},{-10,50}})));
annotation (Placement(transformation(extent={{-30,32},{-10,52}})));
Buildings.Fluid.FixedResistances.PressureDrop totalRes(
final m_flow_nominal=mAir_flow_nominal,
final dp_nominal=dp_nominal,
Expand All @@ -140,7 +140,7 @@ model ChillerDXHeatingEconomizer
annotation (Placement(transformation(extent={{10,30},{30,50}})));
Modelica.Blocks.Math.Gain eff(k=1/etaHea_nominal)
"Heating efficiency"
annotation (Placement(transformation(extent={{120,110},{140,130}})));
annotation (Placement(transformation(extent={{120,100},{140,120}})));
Buildings.Fluid.Sources.Outside out(
final C=fill(0.0004, 1),
final nPorts=3,
Expand Down Expand Up @@ -264,15 +264,17 @@ model ChillerDXHeatingEconomizer
final unit="K",
displayUnit="degC",
final quantity="ThermodynamicTemperature")
"Return air temperature" annotation (Placement(transformation(extent={{202,-90},
{222,-70}}), iconTransformation(extent={{202,-90},{222,-70}})));
"Return air temperature" annotation (Placement(transformation(extent={{200,-90},
{220,-70}}), iconTransformation(extent={{202,-90},{222,-70}})));
Fluid.Sensors.TraceSubstancesTwoPort senTraSub(
redeclare package Medium=MediumA,
final m_flow_nominal=mAir_flow_nominal,
final tau=0)
"Sensor for trace substance"
annotation (Placement(transformation(extent={{40,-50},{20,-30}})));

Modelica.Blocks.Interfaces.RealOutput y_actual "Actual supply fan speed"
annotation (Placement(transformation(extent={{200,162},{220,182}})));
protected
model IdealValve
extends Modelica.Blocks.Icons.Block;
Expand Down Expand Up @@ -366,21 +368,24 @@ protected
end IdealValve;

equation
connect(fanSup.port_b, totalRes.port_a) annotation (Line(points={{-10,40},{10,40}}, color={0,127,255}));
connect(fanSup.P, PFan) annotation (Line(points={{-9,49},{-6,49},{-6,160},{212,
160}}, color={0,0,127}));
connect(eff.y, QHea_flow) annotation (Line(points={{141,120},{176,120},{176,140},
{212,140}}, color={0,0,127}));
connect(fanSup.port_b, totalRes.port_a) annotation (Line(points={{-10,42},
{0,42},{0,40},{10,40}}, color={0,127,255}));
connect(fanSup.P, PFan) annotation (Line(points={{-9,51},{-6,51},{-6,150},{
210,150}}, color={0,0,127}));
connect(eff.y, QHea_flow) annotation (Line(points={{141,110},{166,110},{166,
130},{210,130}},
color={0,0,127}));
connect(weaBus, out.weaBus) annotation (Line(
points={{-180,40},{-140,40},{-140,40.2}},
color={255,204,51},
thickness=0.5), Text(
textString="%first",
index=-1,
extent={{-6,3},{-6,3}}));
connect(senTMixAir.port_b, fanSup.port_a) annotation (Line(points={{-40,40},{-30,40}}, color={0,127,255}));
connect(senTMixAir.port_b, fanSup.port_a) annotation (Line(points={{-40,40},
{-36,40},{-36,42},{-30,42}}, color={0,127,255}));
connect(heaCoi.Q_flow, eff.u) annotation (Line(points={{73,46},{80,46},{80,
120},{118,120}}, color={0,0,127}));
110},{118,110}}, color={0,0,127}));
connect(heaCoi.port_b, cooCoi.port_a2) annotation (Line(points={{72,40},{90,40}}, color={0,127,255}));
connect(cooCoi.port_b2, senTSup.port_a) annotation (Line(points={{110,40},{128,40}}, color={0,127,255}));
connect(cooCoi.port_b1, ideVal.port_1) annotation (Line(
Expand All @@ -393,18 +398,18 @@ equation
connect(souChiWat.ports[1], chi.port_a1) annotation (Line(points={{128,-174},
{128,-174},{110,-174}}, color={0,127,255}));
connect(chi.port_b1, out.ports[1]) annotation (Line(points={{90,-174},{-116,
-174},{-116,42.6667},{-120,42.6667}}, color={0,127,255}));
-174},{-116,38.6667},{-120,38.6667}}, color={0,127,255}));
connect(weaBus.TDryBul, souChiWat.T_in) annotation (Line(
points={{-180,40},{-180,-208},{160,-208},{160,-170},{150,-170}},
color={255,204,51},
thickness=0.5), Text(
textString="%first",
index=-1,
extent={{-6,3},{-6,3}}));
connect(pumChiWat.P, PPum) annotation (Line(points={{111,-79},{111,-52},{180,-52},
{180,100},{212,100}}, color={0,0,127}));
connect(chi.P, PCoo) annotation (Line(points={{89,-177},{84,-177},{84,-128},{98,
-128},{98,-50},{178,-50},{178,120},{212,120}},
connect(pumChiWat.P, PPum) annotation (Line(points={{111,-79},{111,-52},{180,
-52},{180,90},{210,90}}, color={0,0,127}));
connect(chi.P, PCoo) annotation (Line(points={{89,-177},{84,-177},{84,-128},{
98,-128},{98,-50},{178,-50},{178,110},{210,110}},
color={0,0,127}));
connect(ideVal.port_2, chi.port_a2) annotation (Line(points={{86,0.2},{86,-162},{90,-162}},
color={0,127,255}));
Expand All @@ -417,7 +422,8 @@ equation
connect(totalRes.port_b, heaCoi.port_a) annotation (Line(points={{30,40},{52,40}}, color={0,127,255}));
connect(senTSup.port_b, supplyAir) annotation (Line(points={{148,40},{174,40},
{174,60},{202,60}}, color={0,127,255}));
connect(gaiFan.y, fanSup.m_flow_in) annotation (Line(points={{-59,140},{-20,140},{-20,52}}, color={0,0,127}));
connect(gaiFan.y, fanSup.m_flow_in) annotation (Line(points={{-59,140},{
-20,140},{-20,54}}, color={0,0,127}));
connect(booToInt.y, pumChiWat.m_flow_in) annotation (Line(points={{81,-90},{108,-90}}, color={0,0,127}));
connect(booToInt.u, chiOn) annotation (Line(points={{58,-90},{40,-90},{40,-120},
{-220,-120}}, color={255,0,255}));
Expand All @@ -431,10 +437,10 @@ equation
color={0,0,127}));
connect(chi.TSet, TSetChi) annotation (Line(points={{112,-165},{124,-165},{124,
-200},{-220,-200}}, color={0,0,127}));
connect(senTMixAir.T, TMix) annotation (Line(points={{-50,51},{-50,70},{188,70},
{188,-60},{212,-60}}, color={0,0,127}));
connect(senTSup.T, TSup) annotation (Line(points={{138,51},{138,64},{170,64},{
170,-100},{212,-100}}, color={0,0,127}));
connect(senTMixAir.T, TMix) annotation (Line(points={{-50,51},{-50,70},{188,
70},{188,-60},{210,-60}}, color={0,0,127}));
connect(senTSup.T, TSup) annotation (Line(points={{138,51},{138,64},{170,64},
{170,-100},{210,-100}},color={0,0,127}));
connect(out.ports[2], ideEco.port_1) annotation (Line(points={{-120,40},{-120,
40},{-99.8,40}}, color={0,127,255}));
connect(ideEco.port_2, senTMixAir.port_a) annotation (Line(points={{-80.2,40},{-60,40}}, color={0,127,255}));
Expand All @@ -443,13 +449,15 @@ equation
connect(ideEco.port_3, senTRetAir.port_b) annotation (Line(points={{-90,36},{
-90,-40},{-40,-40}}, color={0,127,255}));
connect(senTRetAir.port_b, out.ports[3]) annotation (Line(points={{-40,-40},{
-112,-40},{-112,36},{-120,36},{-120,37.3333}}, color={0,127,255}));
connect(TRet, senTRetAir.T) annotation (Line(points={{212,-80},{174,-80},{174,
-112,-40},{-112,36},{-120,36},{-120,41.3333}}, color={0,127,255}));
connect(TRet, senTRetAir.T) annotation (Line(points={{210,-80},{174,-80},{174,
-20},{-30,-20},{-30,-29}}, color={0,0,127}));
connect(senTRetAir.port_a, senTraSub.port_b) annotation (Line(points={{-20,-40},{20,-40}}, color={0,127,255}));
connect(senTraSub.port_a, returnAir) annotation (Line(points={{40,-40},{120,-40},{120,-20},{202,-20}},
color={0,127,255}));

connect(fanSup.y_actual, y_actual) annotation (Line(points={{-9,49},{0,49},{0,
172},{210,172}}, color={0,0,127}));
annotation (defaultComponentName="chiDXHeaEco",
Icon(coordinateSystem(preserveAspectRatio=false, extent={{-200,-220},
{200,180}}), graphics={
Expand Down
Loading