🌱 (cli; alpha commands): Add unit tests for alpha commands [WiP] #4931

cmallikarjunah · 2025-07-16T08:44:12Z

Issue: 4925

Adding unit tests

linux-foundation-easycla · 2025-07-16T08:44:17Z

The committers listed above are authorized under a signed CLA.

✅ login: cmallikarjunah (c072261, 9ec6d31, dea7d4f)

k8s-ci-robot · 2025-07-16T08:44:21Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cmallikarjunah
Once this PR has been reviewed and has the lgtm label, please assign kavinjsir for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2025-07-16T08:44:21Z

Welcome @cmallikarjunah!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2025-07-16T08:44:22Z

Hi @cmallikarjunah. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

camilamacedo86 · 2025-07-16T09:21:12Z

pkg/cli/alpha/command_test.go

+
+	When("NewScaffoldCommand", func() {
+		It("Testing the NewScaffoldCommand", func() {
+			cmd := NewScaffoldCommand()


The alpha update command internal code it might be nice if we could cover something
However, if you find it too complicated, I suggest skipping pkg/cli/alpha and proceeding to the following directory. ;-)
We have a lot inside that we can add more to, and it is not alpha/experimental staff.

Sure, I am working on the update internal code.

Just a tip:

You can validate the code locally with:

make lint -> for linter check

you can run make lint-fix : to fix automaticly issues ( not all is fixed but is very helpful )

When you finish this one please remove WIP from the title so that we are aware of and we can review/get merged get done ;-)

Hi @cmallikarjunah, I'm currently working on alpha internal update package, are you working on the same or is it different?. I wanted to clarify so that we dont duplicate the work :-)

https://github.com/kubernetes-sigs/kubebuilder/tree/master/pkg/cli/alpha/internal/update

Ya it's the same @mayuka-c.
Was working on functions of prepare.go yesterday. Planning to continue.
There was no WiP or status for it so I picked it upon Camila's suggestion.

Ok, no worries, you can continue

camilamacedo86 · 2025-07-20T23:29:25Z

pkg/cli/alpha/internal/update/prepare.go

@@ -75,7 +75,7 @@ func (opts *Update) defineFromVersion(config store.Store) (string, error) {

 func (opts *Update) defineToVersion() string {
 	if len(opts.ToVersion) != 0 {
-		if !strings.HasPrefix(opts.FromVersion, "v") {
+		if !strings.HasPrefix(opts.ToVersion, "v") {


Could you please rebase with master?
So that we have no this change it is fixed and merged now 👍

camilamacedo86 · 2025-07-20T23:31:05Z

pkg/cli/alpha/internal/update/prepare_test.go

+			Entry("options", &Update{ToVersion: "v1.1.0"}),
+			Entry("options", &Update{FromVersion: "1.0.0"}),
+			Entry("options", &Update{ToVersion: "1.1.0"}),
+			Entry("options", &Update{}),


Can we reduce the number of test cases here?

Do we really need all of them to cover the intended scenarios?
It seems like we’re primarily validating support for:

FromVersion and ToVersion with and without the v prefix

Presence or absence of FromBranch

We’re not actually validating SemVer parsing here, so duplicating every combination may be unnecessary.
Maybe we could simplify this to focus on meaningful permutations only?

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 16, 2025

k8s-ci-robot requested review from rashmigottipati and varshaprasad96 July 16, 2025 08:44

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 16, 2025

cmallikarjunah changed the title ~~🌱(cli; alpha commands): Add unit tests for alpha commands~~ 🌱WiP (cli; alpha commands): Add unit tests for alpha commands Jul 16, 2025

cmallikarjunah changed the title ~~🌱WiP (cli; alpha commands): Add unit tests for alpha commands~~ [WiP] 🌱 (cli; alpha commands): Add unit tests for alpha commands Jul 16, 2025

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 16, 2025

cmallikarjunah mentioned this pull request Jul 16, 2025

[Help Wanted] - Increase the coverage of unit tests #4925

Open

camilamacedo86 reviewed Jul 16, 2025

View reviewed changes

cmallikarjunah added 2 commits July 18, 2025 14:06

Added pkg/alpha/command_test.go

9ec6d31

Added pkg/alpha/update_test.go

c072261

cmallikarjunah force-pushed the issue-4925-add-UTs branch from 7c5b2d9 to c072261 Compare July 18, 2025 08:36

cmallikarjunah changed the title ~~[WiP] 🌱 (cli; alpha commands): Add unit tests for alpha commands~~ 🌱 (cli; alpha commands): Add unit tests for alpha commands Jul 18, 2025

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 18, 2025

Add pkg/cli/alpha/internal/update/prepare_test.go

dea7d4f

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 20, 2025

cmallikarjunah changed the title ~~🌱 (cli; alpha commands): Add unit tests for alpha commands~~ 🌱 (cli; alpha commands): Add unit tests for alpha commands [WiP] Jul 20, 2025

camilamacedo86 reviewed Jul 20, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

🌱 (cli; alpha commands): Add unit tests for alpha commands [WiP] #4931

🌱 (cli; alpha commands): Add unit tests for alpha commands [WiP] #4931

cmallikarjunah commented Jul 16, 2025

Uh oh!

linux-foundation-easycla bot commented Jul 16, 2025 •

edited

Loading

Uh oh!

k8s-ci-robot commented Jul 16, 2025

Uh oh!

k8s-ci-robot commented Jul 16, 2025

Uh oh!

k8s-ci-robot commented Jul 16, 2025

Uh oh!

camilamacedo86 Jul 16, 2025

Uh oh!

cmallikarjunah Jul 17, 2025

Uh oh!

camilamacedo86 Jul 17, 2025

Uh oh!

camilamacedo86 Jul 17, 2025

Uh oh!

mayuka-c Jul 18, 2025

Uh oh!

cmallikarjunah Jul 18, 2025 •

edited

Loading

Uh oh!

mayuka-c Jul 18, 2025

Uh oh!

camilamacedo86 Jul 20, 2025

Uh oh!

camilamacedo86 Jul 20, 2025 •

edited

Loading

Uh oh!

Uh oh!

🌱 (cli; alpha commands): Add unit tests for alpha commands [WiP] #4931

Are you sure you want to change the base?

🌱 (cli; alpha commands): Add unit tests for alpha commands [WiP] #4931

Conversation

cmallikarjunah commented Jul 16, 2025

Uh oh!

linux-foundation-easycla bot commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Jul 16, 2025

Uh oh!

k8s-ci-robot commented Jul 16, 2025

Uh oh!

k8s-ci-robot commented Jul 16, 2025

Uh oh!

camilamacedo86 Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

cmallikarjunah Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

camilamacedo86 Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

camilamacedo86 Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

mayuka-c Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

cmallikarjunah Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mayuka-c Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

camilamacedo86 Jul 20, 2025

Choose a reason for hiding this comment

Uh oh!

camilamacedo86 Jul 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

linux-foundation-easycla bot commented Jul 16, 2025 •

edited

Loading

cmallikarjunah Jul 18, 2025 •

edited

Loading

camilamacedo86 Jul 20, 2025 •

edited

Loading