-
Notifications
You must be signed in to change notification settings - Fork 1.6k
🌱 Add unit tests for alpha/internal/update #4931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,178 @@ | ||||||||||
/* | ||||||||||
Copyright 2025 The Kubernetes Authors. | ||||||||||
|
||||||||||
Licensed under the Apache License, Version 2.0 (the "License"); | ||||||||||
you may not use this file except in compliance with the License. | ||||||||||
You may obtain a copy of the License at | ||||||||||
|
||||||||||
http://www.apache.org/licenses/LICENSE-2.0 | ||||||||||
|
||||||||||
Unless required by applicable law or agreed to in writing, software | ||||||||||
distributed under the License is distributed on an "AS IS" BASIS, | ||||||||||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||||||||||
See the License for the specific language governing permissions and | ||||||||||
limitations under the License. | ||||||||||
*/ | ||||||||||
|
||||||||||
package update | ||||||||||
|
||||||||||
import ( | ||||||||||
"os" | ||||||||||
"path/filepath" | ||||||||||
"testing" | ||||||||||
|
||||||||||
"github.com/h2non/gock" | ||||||||||
. "github.com/onsi/ginkgo/v2" | ||||||||||
. "github.com/onsi/gomega" | ||||||||||
|
||||||||||
"sigs.k8s.io/kubebuilder/v4/pkg/cli/alpha/internal/common" | ||||||||||
"sigs.k8s.io/kubebuilder/v4/pkg/config" | ||||||||||
"sigs.k8s.io/kubebuilder/v4/pkg/config/store/yaml" | ||||||||||
v3 "sigs.k8s.io/kubebuilder/v4/pkg/config/v3" | ||||||||||
) | ||||||||||
|
||||||||||
func TestCommand(t *testing.T) { | ||||||||||
RegisterFailHandler(Fail) | ||||||||||
RunSpecs(t, "update") | ||||||||||
} | ||||||||||
|
||||||||||
var _ = Describe("Prepare for internal update", func() { | ||||||||||
var ( | ||||||||||
tmpDir string | ||||||||||
workDir string | ||||||||||
projectFile string | ||||||||||
err error | ||||||||||
) | ||||||||||
|
||||||||||
BeforeEach(func() { | ||||||||||
workDir, err = os.Getwd() | ||||||||||
Expect(err).ToNot(HaveOccurred()) | ||||||||||
|
||||||||||
tmpDir, err = os.MkdirTemp("", "kubebuilder-prepare-test") | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I know these two tests are being merged, but I think we should change them a bit. We can use a shared way to create the temp dir and use the kubebuilder binary, like this example:
Right now, the helper is under e2e tests. So maybe we copy that code and make something like That way, we always create temp dirs the same way and only need to update one place if things change. I’m okay to merge this as is, but we should fix this later. Can you please open an issue listing what we need to change? If you want to help with a better design too, that would be awesome. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sure, will create an issue for the alteration. |
||||||||||
Expect(err).ToNot(HaveOccurred()) | ||||||||||
err = os.Chdir(tmpDir) | ||||||||||
Expect(err).ToNot(HaveOccurred()) | ||||||||||
|
||||||||||
projectFile = filepath.Join(tmpDir, yaml.DefaultPath) | ||||||||||
|
||||||||||
config.Register(config.Version{Number: 3}, func() config.Config { | ||||||||||
return &v3.Cfg{Version: config.Version{Number: 3}, CliVersion: "1.0.0"} | ||||||||||
}) | ||||||||||
|
||||||||||
gock.New("https://api.github.com"). | ||||||||||
Get("/repos/kubernetes-sigs/kubebuilder/releases/latest"). | ||||||||||
Reply(200). | ||||||||||
JSON(map[string]string{ | ||||||||||
"tag_name": "v1.1.0", | ||||||||||
}) | ||||||||||
}) | ||||||||||
|
||||||||||
AfterEach(func() { | ||||||||||
err = os.Chdir(workDir) | ||||||||||
Expect(err).ToNot(HaveOccurred()) | ||||||||||
|
||||||||||
err = os.RemoveAll(tmpDir) | ||||||||||
Expect(err).ToNot(HaveOccurred()) | ||||||||||
defer gock.Off() | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||||||||||
}) | ||||||||||
|
||||||||||
Context("Prepare", func() { | ||||||||||
DescribeTable("should succeed for valid options", | ||||||||||
func(options *Update) { | ||||||||||
const version = `version: "3"` | ||||||||||
Expect(os.WriteFile(projectFile, []byte(version), 0o644)).To(Succeed()) | ||||||||||
|
||||||||||
result := options.Prepare() | ||||||||||
Expect(result).ToNot(HaveOccurred()) | ||||||||||
Expect(options.Prepare()).To(Succeed()) | ||||||||||
cmallikarjunah marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||
Expect(options.FromVersion).To(Equal("v1.0.0")) | ||||||||||
Expect(options.ToVersion).To(Equal("v1.1.0")) | ||||||||||
}, | ||||||||||
Entry("options", &Update{FromVersion: "v1.0.0", ToVersion: "v1.1.0", FromBranch: "test"}), | ||||||||||
Entry("options", &Update{FromVersion: "1.0.0", ToVersion: "1.1.0", FromBranch: "test"}), | ||||||||||
Entry("options", &Update{FromVersion: "v1.0.0", ToVersion: "v1.1.0"}), | ||||||||||
Entry("options", &Update{}), | ||||||||||
cmallikarjunah marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||
) | ||||||||||
|
||||||||||
DescribeTable("Should fail to prepare if project path is undetermined", | ||||||||||
func(options *Update) { | ||||||||||
err = options.Prepare() | ||||||||||
Expect(err).To(HaveOccurred()) | ||||||||||
Expect(err.Error()).Should(ContainSubstring("failed to determine project path")) | ||||||||||
}, | ||||||||||
Entry("options", &Update{FromVersion: "v1.0.0", ToVersion: "v1.1.0", FromBranch: "test"}), | ||||||||||
) | ||||||||||
|
||||||||||
DescribeTable("Should fail if PROJECT config could not be loaded", | ||||||||||
func(options *Update) { | ||||||||||
const version = "" | ||||||||||
Expect(os.WriteFile(projectFile, []byte(version), 0o644)).To(Succeed()) | ||||||||||
|
||||||||||
err := options.Prepare() | ||||||||||
Expect(err).To(HaveOccurred()) | ||||||||||
Expect(err.Error()).Should(ContainSubstring("failed to load PROJECT config")) | ||||||||||
}, | ||||||||||
Entry("options", &Update{FromVersion: "v1.0.0", ToVersion: "v1.1.0", FromBranch: "test"}), | ||||||||||
) | ||||||||||
|
||||||||||
DescribeTable("Should fail if FromVersion cannot be determined", | ||||||||||
func(options *Update) { | ||||||||||
config.Register(config.Version{Number: 3}, func() config.Config { | ||||||||||
return &v3.Cfg{Version: config.Version{Number: 3}} | ||||||||||
}) | ||||||||||
|
||||||||||
const version = `version: "3"` | ||||||||||
Expect(os.WriteFile(projectFile, []byte(version), 0o644)).To(Succeed()) | ||||||||||
Expect(options.FromVersion).To(BeEquivalentTo("")) | ||||||||||
}, | ||||||||||
Entry("options", &Update{}), | ||||||||||
) | ||||||||||
}) | ||||||||||
|
||||||||||
Context("DefineFromVersion", func() { | ||||||||||
DescribeTable("Should succeed when branch or CliVersion in Project config is present", | ||||||||||
func(options *Update) { | ||||||||||
const version = `version: "3"` | ||||||||||
Expect(os.WriteFile(projectFile, []byte(version), 0o644)).To(Succeed()) | ||||||||||
|
||||||||||
config, err := common.LoadProjectConfig(tmpDir) | ||||||||||
Expect(err).ToNot(HaveOccurred()) | ||||||||||
fromVersion, err := options.defineFromVersion(config) | ||||||||||
Expect(err).ToNot(HaveOccurred()) | ||||||||||
Expect(fromVersion).To(BeEquivalentTo("v1.0.0")) | ||||||||||
}, | ||||||||||
Entry("options", &Update{FromVersion: ""}), | ||||||||||
Entry("options", &Update{FromVersion: "1.0.0"}), | ||||||||||
) | ||||||||||
DescribeTable("Should fail when --from-version and CliVersion in Project config both are absent", | ||||||||||
func(options *Update) { | ||||||||||
config.Register(config.Version{Number: 3}, func() config.Config { | ||||||||||
return &v3.Cfg{Version: config.Version{Number: 3}} | ||||||||||
}) | ||||||||||
|
||||||||||
const version = `version: "3"` | ||||||||||
Expect(os.WriteFile(projectFile, []byte(version), 0o644)).To(Succeed()) | ||||||||||
|
||||||||||
config, err := common.LoadProjectConfig(tmpDir) | ||||||||||
Expect(err).NotTo(HaveOccurred()) | ||||||||||
fromVersion, err := options.defineFromVersion(config) | ||||||||||
Expect(err).To(HaveOccurred()) | ||||||||||
Expect(err.Error()).To(ContainSubstring("no version specified in PROJECT file")) | ||||||||||
Expect(fromVersion).To(Equal("")) | ||||||||||
}, | ||||||||||
Entry("options", &Update{FromVersion: ""}), | ||||||||||
) | ||||||||||
}) | ||||||||||
|
||||||||||
Context("DefineToVersion", func() { | ||||||||||
DescribeTable("Should succeed.", | ||||||||||
func(options *Update) { | ||||||||||
toVersion := options.defineToVersion() | ||||||||||
Expect(toVersion).To(BeEquivalentTo("v1.1.0")) | ||||||||||
}, | ||||||||||
Entry("options", &Update{ToVersion: "1.1.0"}), | ||||||||||
Entry("options", &Update{ToVersion: "v1.1.0"}), | ||||||||||
Entry("options", &Update{}), | ||||||||||
) | ||||||||||
}) | ||||||||||
}) |
Uh oh!
There was an error while loading. Please reload this page.