[Help Wanted] - Increase the coverage of unit tests

[camilamacedo86]

We've made good progress with e2e tests for Kubebuilder. However, we have been decreasing the amount of unit tests as shown in Coveralls. To enforce coverage in CI, we now need to improve unit test coverage.

What we need to do:

• Add more unit tests
• Add a check in the CI to enforce adding unit tests

[cmallikarjunah]

/assign

[mayuka-c]

@cmallikarjunah Can you please let me know if you have already started working on this?. Also on which files you're currently working to add unit tests. I can take up other files so that we can split the work (avoiding duplication) and complete the coverage :)

[mayuka-c]

/assign

[camilamacedo86]

Hi @mayuka-c,

This one will likely involve quite a bit of work across multiple people.

I recommend using the channel to coordinate and split up the work as needed. It would also be helpful to open a WIP PR early—don’t worry about perfection—just enough to show the direction you're heading in.

If coordination via the channel doesn’t work out and it feels like we need something more structured, I’m happy to help set up a better plan.

Since @cmallikarjunah was the first to ping, it might make sense for them to start from the top of the packages/dirs. You could begin from the bottom up to avoid overlapping efforts.

Let me know how it goes!

[mayuka-c]

Hi @mayuka-c,

This one will likely involve quite a bit of work across multiple people.

I recommend using the channel to coordinate and split up the work as needed. It would also be helpful to open a WIP PR early—don’t worry about perfection—just enough to show the direction you're heading in.

If coordination via the channel doesn’t work out and it feels like we need something more structured, I’m happy to help set up a better plan.

Since @cmallikarjunah was the first to ping, it might make sense for them to start from the top of the packages/dirs. You could begin from the bottom up to avoid overlapping efforts.

Let me know how it goes!

Sure @camilamacedo86,

Thank you for your suggestions :)

I will kind of do bottom-up approach covering util/ helper functions. Will be putting up a PR to make sure I'm heading in right direction. Thank you for your help :)

[cmallikarjunah]

Hi @camilamacedo86 /@mayuka-c,

I am starting with:
pkg/alpha/command.go
pkg/alpha/update.go.

Will be putting up the PR(WiP) soon.
@mayuka-c Can you also mention the files you start with for clarity.

[mayuka-c]

Hi @cmallikarjunah,
I'm taking up bottom up approach, so taking care of adding UTs to helper/ util methods.
Currently working under pkg/cli/alpha/internal

[mayuka-c]

@camilamacedo86 Here is the PR which adds UT under common pkg: #4928. Please review and please do suggest for improvements. Shall we take up UTs for diff pkgs seperately or shall we combine all of them together?

I personally feel having seperate PRs for each package would be cleaner and more easier to review. Please do let me know

[afzal442]

/assign