-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CEDS processing #26
Conversation
Co-authored-by: chrisroadmap <[email protected]>
Coming back to this tomorrow, but quick answers:
|
|
Ok great, this should be ready for you then @jkikstra |
Great work @chrisroadmap and @znichollscr. Things I note:
So, I suggest that once we move to the updated/final new SSP projections in the harmonization, we do:
|
Did 1 and 5 (+3 partially; unit wish, but not the unit conversion) in #31; please feel free to merge that in and continue. |
My instinct is yes
Sorry if this is answered already, I would have assumed we include this too...
Sounds good. My instinct would be to do the masking ourselves based on CEDS gridded data (that gives us the most control and means we can use the same mask for CEDS and BB4CMIP).
Perfect thanks. |
Ceds global national jsk
Hacked in now |
Done (surprisingly clean, different to last time :) ) |
OK, I found two things, which I will now work on committing, before merging.
|
All good, just rip out those weird paths then and should run smoothly...
Nice |
Now, I wonder if I'm the only person that would prefer to see N2O reported in Mt rather than kt. The numbers are more tractable (order 10 Mt/yr not 10000 kt/yr), it's consistent with CH4 and the SLCFs, and it has a natural synergy with the ppb atmospheric concentration unit. Can we do this? |
I think we should do this for RCMIP. For this, which is targeted at IAM people, I would just stick with what IAM teams are used to in order to minimise headaches. |
Agree with Zeb. |
- Clarify and write out separately "global" region (for international emissions) + some updated checks (esp. for aircraft and international shipping) - Fix and simplify unit handling, reverting previous commits - assert that '6B_Other-not-in-total' is zero (see #32 (comment))
@jkikstra nice and simple one I think. Seems to run smoothly with no issue.
@chrisroadmap @jkikstra a few questions:
in the current data folder setup, they are separate so maybe that question is already answered?Ignore me that split is to do with raw data, not processed data)