Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CEDS Sector Mapping: 6B_Other-not-in-total #32

Closed
jkikstra opened this issue Jan 9, 2025 · 5 comments
Closed

CEDS Sector Mapping: 6B_Other-not-in-total #32

jkikstra opened this issue Jan 9, 2025 · 5 comments

Comments

@jkikstra
Copy link
Collaborator

jkikstra commented Jan 9, 2025

#26 (comment)

  1. meaning we only exclude '6B_Other-not-in-total'

Sorry if this is answered already, I would have assumed we include this too...

I took the sector mapping file from CMIP6 and was building on top of that.
After Steve reviewed this mapping for CMIP7, he suggested to add back in '7BC_Indirect-N2O-non-agricultural' (#29).
Steve did not suggest to add in '6B_Other-not-in-total' anywhere.

Above, Zeb is now saying to add it back in.
To me, the name ("not-in-total") suggests we should ignore it?

Steve, can you explain? I find it very difficult to try to get information about these things from CEDS documentation (maybe it is somewhere).

Will we need '6B_Other-not-in-total' to get to the "total anthropogenic" emissions required as input to climate emulators?
Is this included in the historical data you provide for the ESM historical runs?

@ssmithClimate & @znichollscr

@jkikstra jkikstra changed the title CEDS Sector Mapping: CEDS Sector Mapping: 6B_Other-not-in-total Jan 9, 2025
@znichollscr
Copy link
Collaborator

To me, the name ("not-in-total") suggests we should ignore it?

Ah I missed that, perhaps you're right (I guess I'm not sure what the name means, does "not-in-total" mean "don't put this in the total" or "this isn't in to the total, so when you're making the total, don't forget to include it").

@ssmithClimate
Copy link

It's not something we have used to date - we put it in our mapping just be complete in case we needed to use it (It was in some of the other sector naming systems we were drawing from). Fine to exclude it.

@znicholls
Copy link

@jkikstra we should probably assert that it is zero (i.e. really not used) just to be safe in case something changes and we don't notice.

jkikstra added a commit that referenced this issue Jan 9, 2025
- Clarify and write out separately "global" region (for international emissions) + some updated checks (esp. for aircraft and international shipping)
- Fix and simplify unit handling, reverting previous commits
- assert that '6B_Other-not-in-total' is zero (see #32 (comment))
@jkikstra
Copy link
Collaborator Author

jkikstra commented Jan 9, 2025

Okay; did that now with the merge of #26.

@jkikstra
Copy link
Collaborator Author

Since this topic seems to be handled satisfactorily with lines

# '6B_Other-not-in-total' is not assigned, and normally not used by CEDS. To be certain that we notice it when something
# ... changes, we check that it is indeed zero, such that we are not missing anything.
year_cols = ceds.columns.astype(int)
first_year = year_cols[0]
last_year = year_cols[-1]
sum_of_6B_other = (
ceds.loc[pix.ismatch(sector_59="6B_Other-not-in-total")]
.sum(axis=1) # sum across years
.sum(axis=0) # sum across species and countries
)
assert sum_of_6B_other == 0
I'll close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants