wgsl: Implement AbstractInt negation execution tests #3390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoddicus
added a commit
to zoddicus/cts
that referenced
this pull request
Feb 12, 2024
There is no compound tests, since += is not defined for consts, and AbstractFloats are always const. Lots of little tweaks in the PR wrt to renaming things to distinguish between AbstractFloat and AbstractInt, and threading generics through to allow reusing the same code for number and bigint. Issue gpuweb#3390
7 tasks
ben-clayton
approved these changes
Feb 13, 2024
zoddicus
force-pushed
the
addAbstractIntNegationExecutionTests
branch
from
22e5973 to
6d94586
Compare
zoddicus
added a commit
to zoddicus/cts
that referenced
this pull request
Feb 13, 2024
There is no compound tests, since += is not defined for consts, and AbstractFloats are always const. Lots of little tweaks in the PR wrt to renaming things to distinguish between AbstractFloat and AbstractInt, and threading generics through to allow reusing the same code for number and bigint. Issue gpuweb#3390
zoddicus
added a commit
that referenced
this pull request
Feb 13, 2024
There is no compound tests, since += is not defined for consts, and AbstractFloats are always const. Lots of little tweaks in the PR wrt to renaming things to distinguish between AbstractFloat and AbstractInt, and threading generics through to allow reusing the same code for number and bigint. Issue #3390
zoddicus
added a commit
to zoddicus/cts
that referenced
this pull request
Feb 13, 2024
7 tasks
zoddicus
added a commit
to zoddicus/cts
that referenced
this pull request
Feb 13, 2024
7 tasks
zoddicus
added a commit
to zoddicus/cts
that referenced
this pull request
Feb 13, 2024
7 tasks
zoddicus
added a commit
that referenced
this pull request
Feb 13, 2024
zoddicus
added a commit
to zoddicus/cts
that referenced
this pull request
Feb 13, 2024
zoddicus
added a commit
to zoddicus/cts
that referenced
this pull request
Feb 13, 2024
zoddicus
added a commit
that referenced
this pull request
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1626
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.