Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgsl: Implement AbstractInt multiplication execution tests #3398

Merged

Conversation

zoddicus
Copy link
Contributor

@zoddicus zoddicus commented Feb 13, 2024

Issue #1626


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@zoddicus zoddicus added the wgsl label Feb 13, 2024
@zoddicus zoddicus self-assigned this Feb 13, 2024
@zoddicus zoddicus force-pushed the addAbstractIntMultiplicationExecutionTests branch from 7b3e94b to e43b2fe Compare February 13, 2024 21:27
@zoddicus zoddicus merged commit 42b0189 into gpuweb:main Feb 13, 2024
1 check passed
@zoddicus zoddicus deleted the addAbstractIntMultiplicationExecutionTests branch February 13, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants