Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgsl: Implement AbstractFloat addition execution tests #3392

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

zoddicus
Copy link
Contributor

There is no compound tests, since += is not defined for consts, and AbstractFloats are always const.

Lots of little tweaks in the PR wrt to renaming things to distinguish between AbstractFloat and AbstractInt, and threading generics through to allow reusing the same code for number and bigint.

Issue #3390


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@zoddicus zoddicus added the wgsl label Feb 12, 2024
@zoddicus zoddicus self-assigned this Feb 12, 2024
There is no compound tests, since += is not defined for consts, and
AbstractFloats are always const.

Lots of little tweaks in the PR wrt to renaming things to distinguish
between AbstractFloat and AbstractInt, and threading generics through
to allow reusing the same code for number and bigint.

Issue gpuweb#3390
@zoddicus zoddicus force-pushed the addAbstractIntAdditionExecutionTests branch from 1acdb0d to bfb6126 Compare February 13, 2024 16:36
@zoddicus zoddicus merged commit a42c759 into gpuweb:main Feb 13, 2024
1 check passed
@zoddicus zoddicus deleted the addAbstractIntAdditionExecutionTests branch February 13, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants