Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes flaky test because parameters were changed when the test was ran. #3096

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

lokokung
Copy link
Contributor

@lokokung lokokung commented Oct 25, 2023

Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@lokokung lokokung requested a review from kainino0x October 25, 2023 22:15
@kainino0x kainino0x enabled auto-merge (squash) October 25, 2023 22:15
kainino0x added a commit to kainino0x/cts that referenced this pull request Oct 25, 2023
This should hopefully categorically prevent bugs like the one fixed in
gpuweb#3096
@kainino0x kainino0x merged commit e5f120e into gpuweb:main Oct 25, 2023
2 checks passed
@github-actions
Copy link

Previews, as seen when this build job started (b7154a2):
Run tests | View tsdoc

kainino0x added a commit to kainino0x/cts that referenced this pull request Oct 25, 2023
This should hopefully categorically prevent bugs like the one fixed in
gpuweb#3096
kainino0x added a commit that referenced this pull request Oct 26, 2023
…odified (#3097)

This should hopefully categorically prevent bugs like the one fixed in
#3096
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants