Fixes flaky test because parameters were changed when the test was ra…

…n. (#3096)
gpuweb · Oct 25, 2023 · e5f120e · e5f120e
1 parent 2be0e90
commit e5f120e
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/src/webgpu/api/validation/compute_pipeline.spec.ts b/src/webgpu/api/validation/compute_pipeline.spec.ts
@@ -233,7 +233,7 @@ Tests calling createComputePipeline(Async) validation for compute workgroup_size
         [1, 1, 63],
         [1, 1, 64],
         [1, 1, 65],
-      ])
+      ] as const)
   )
   .fn(t => {
     const { isAsync, size } = t.params;
@@ -251,13 +251,14 @@ Tests calling createComputePipeline(Async) validation for compute workgroup_size
       },
     };
 
-    size[1] = size[1] ?? 1;
-    size[2] = size[2] ?? 1;
+    const workgroupX = size[0];
+    const workgroupY = size[1] ?? 1;
+    const workgroupZ = size[2] ?? 1;
 
     const _success =
-      size[0] <= t.device.limits.maxComputeWorkgroupSizeX &&
-      size[1] <= t.device.limits.maxComputeWorkgroupSizeY &&
-      size[2] <= t.device.limits.maxComputeWorkgroupSizeZ;
+      workgroupX <= t.device.limits.maxComputeWorkgroupSizeX &&
+      workgroupY <= t.device.limits.maxComputeWorkgroupSizeY &&
+      workgroupZ <= t.device.limits.maxComputeWorkgroupSizeZ;
     t.doCreateComputePipelineTest(isAsync, _success, descriptor);
   });