-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make test params readonly so they can't be accidentally permanently modified #3097
Conversation
This should hopefully categorically prevent bugs like the one fixed in gpuweb#3096
Previews, as seen when this build job started (d6be35d): |
Previews, as seen when this build job started (fd23313): |
Previews, as seen when this build job started (3b67a77): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah... the typing for the tuples is rather nasty lol... The nested arrays is also not the prettiest... Otherwise seems fine. Just out of curiosity, if we pass a super large tuple or quadruply nested array, does it just give a compile error? Or will it do something else?
Nested array should be fine, as it's recursive. If we pass a tuple larger than 7, it will coerce to an array, e.g. |
This should hopefully categorically prevent bugs like the one fixed in #3096.
Verified this only has the expected changes on the generated JS by comparing the build
out
directory.https://gist.github.com/kainino0x/2851c43552987738ef2e9125389eb092
Only the unittests changed, and of course they pass (they're checked on presubmit).
Issue: None
Requirements for PR author:
.unimplemented()
./** documented */
and new helper files are found inhelper_index.txt
.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.