chore: Add Transport interface and Toolbox Transport #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twishabansal
added
the
priority: p1
dishaprakash
force-pushed
the
add-toolbox-transport
branch
from
d7eb684 to
14f6932
Compare
This was referenced Dec 17, 2025
twishabansal
requested changes
Dec 23, 2025
twishabansal
requested changes
Jan 6, 2026
| } | ||
|
|
||
| payloadBytes, err := json.Marshal(payload) | ||
| invocationURL := fmt.Sprintf("%s/api/tool/%s/invoke", t.baseURL, toolName) |
Contributor
There was a problem hiding this comment.
Should we use the joinpath function here?
twishabansal
approved these changes
Jan 7, 2026
| } | ||
|
|
||
| payloadBytes, err := json.Marshal(payload) | ||
| invocationURL := fmt.Sprintf("%s/api/tool/%s/invoke", t.baseURL, toolName) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR establishes the foundational transport layer architecture required to support the Model Context Protocol (MCP) alongside the existing HTTP protocol.
This PR purely adds the structure for the transport layer.
Changes made:
Transportinterface and shared types incore/transport, effectively decoupling protocol mechanics from the high-level client logic.toolboxtransportpackage, which encapsulates the native Toolbox HTTP request logic into a reusable transport implementation.core/transport/types.goalong with the associated tests (This is being done to remove circular dependency)Subsequent PRs will contain:
corepackage to de-duplicate the shared types to provide backward compatibility.