feat: Add support for MCP protocol in core SDK #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dishaprakash
force-pushed
the
add-mcp-v20250618
branch
from
d838741 to
6510bbb
Compare
dishaprakash
force-pushed
the
integrate-transport
branch
from
0c49d4f to
fb2b3e9
Compare
dishaprakash
force-pushed
the
add-mcp-v20250618
branch
from
6510bbb to
7332a6a
Compare
dishaprakash
force-pushed
the
integrate-transport
branch
from
ccfc3f5 to
df16239
Compare
twishabansal
added
the
priority: p1
twishabansal
assigned
dishaprakash and
twishabansal and unassigned
twishabansal and
dishaprakash
dishaprakash
force-pushed
the
add-mcp-v20250618
branch
2 times, most recently
from
b9a60a8 to
d439c55
Compare
dishaprakash
force-pushed
the
integrate-transport
branch
from
c6ae916 to
2ed09b3
Compare
dishaprakash
force-pushed
the
add-mcp-v20250618
branch
from
d439c55 to
21fda7c
Compare
dishaprakash
force-pushed
the
integrate-transport
branch
from
2ed09b3 to
42ffc59
Compare
twishabansal
reviewed
Jan 6, 2026
| func TestE2E_ContextHandling(t *testing.T) { | ||
| newClient := func(t *testing.T) *core.ToolboxClient { | ||
| client, err := core.NewToolboxClient("http://localhost:5000") | ||
| client, err := getNewToolboxClient() |
Contributor
There was a problem hiding this comment.
Is this a breaking change for the users?
Contributor
Author
There was a problem hiding this comment.
Similar to Python, if users want to continue the usage of the native Toolbox REST protocol then yes. But we are defaulting to the latest MCP version.
Since this E2E test is for the Toolbox Protocol, we have to use the functional option to mention the protocol
dishaprakash
force-pushed
the
add-mcp-v20250618
branch
from
21fda7c to
1cc4528
Compare
dishaprakash
force-pushed
the
integrate-transport
branch
from
42ffc59 to
ff077ca
Compare
dishaprakash
force-pushed
the
add-mcp-v20250618
branch
from
1cc4528 to
028b426
Compare
dishaprakash
force-pushed
the
integrate-transport
branch
from
ff077ca to
c9e4b5c
Compare
twishabansal
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR no. 5 - Adding support for MCP protocol in core SDK
PR no.4 - #132
PR no.3 - #131
PR no.2 - #128
PR no.1 - #126
Key Changes
Protocoltype and constantsWithProtocolto allow configuring the client version, including validation to prevent duplicate assignment.NewToolboxClientto instantiate the correct underlying transport (mcp20250618, mcp20250326, mcp20241105, toolbox) based on the configuration.protocolandtransportfields toToolboxClientto store state and configuration.WithProtocol(verifying configuration and error handling).GetSupportedMcpVersions.