-
Notifications
You must be signed in to change notification settings - Fork 11
feat: Add MCP Transport version 2024-11-05 #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dishaprakash
wants to merge
20
commits into
add-toolbox-transport
Choose a base branch
from
add-mcp-v20241105
base: add-toolbox-transport
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,303
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c29bb09 to
4c0f3e5
Compare
d7eb684 to
14f6932
Compare
4a216a2 to
b7f2c50
Compare
anubhav756
approved these changes
Dec 18, 2025
anubhav756
approved these changes
Dec 18, 2025
Contributor
anubhav756
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (the coverage might need a bump)
This was referenced Dec 18, 2025
d7a08f7 to
3dcc3b5
Compare
twishabansal
approved these changes
Jan 6, 2026
92eef10 to
aa04774
Compare
e715006 to
2f063eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR no. 2 - Adding MCP v20241105
PR no.1 - Adding Toolbox HTTP Transport
This PR adds the MCP v2024-11-05 transport to the Go SDK.
It introduces the v20241105 package with protocol-specific types and full handshake logic.
BaseMcpTransport is also added to serve as a base for all mcp version implementations.
Comprehensive tests are included to verify session initialization, tool schema conversion, and request handling.