Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "start-proxy: Skip proxy setup if no credentials are available" #2740

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

marcogario
Copy link
Contributor

@marcogario marcogario commented Jan 29, 2025

Reverts #2724

The logic setting the proxy for maven fails with the empty variables. Though the error is non-fatal, this is not really improving the situation and might actually make it worse.

@Copilot Copilot bot review requested due to automatic review settings January 29, 2025 08:35
@marcogario marcogario requested a review from a team as a code owner January 29, 2025 08:35

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/start-proxy-action.ts:102

  • By removing the check for zero credentials, this code proceeds with proxy setup even if the credentials array is empty, which may lead to unexpected behavior or errors. Reintroduce a condition for the empty credentials scenario, or confirm that subsequent logic gracefully handles it.
logger.info(

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

@marcogario marcogario marked this pull request as draft January 29, 2025 08:36
@marcogario marcogario marked this pull request as ready for review January 29, 2025 08:41
@marcogario marcogario enabled auto-merge January 29, 2025 09:01
@marcogario marcogario merged commit 14b9c0e into main Jan 29, 2025
525 checks passed
@marcogario marcogario deleted the revert-2724-marcogario/skip_proxy branch January 29, 2025 10:03
@github-actions github-actions bot mentioned this pull request Jan 29, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants