Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into releases/v3 #2743

Merged
merged 14 commits into from
Jan 29, 2025
Merged

Merge main into releases/v3 #2743

merged 14 commits into from
Jan 29, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 29, 2025

Merging 797fb30 into releases/v3.

Conductor for this PR is @marcogario.

Contains the following pull requests:

Please do the following:

  • Ensure the CHANGELOG displays the correct version and date.
  • Ensure the CHANGELOG includes all relevant, user-facing changes since the last release.
  • Check that there are not any unexpected commits being merged into the releases/v3 branch.
  • Ensure the docs team is aware of any documentation changes that need to be released.
  • Mark the PR as ready for review to trigger the full set of PR checks.
  • Approve and merge this PR. Make sure Create a merge commit is selected rather than Squash and merge or Rebase and merge.
  • Merge the mergeback PR that will automatically be created once this PR is merged.
  • Merge all backport PRs to older release branches, that will automatically be created once this PR is merged.

@marcogario marcogario marked this pull request as ready for review January 29, 2025 12:46
@Copilot Copilot bot review requested due to automatic review settings January 29, 2025 12:46
@marcogario marcogario requested a review from a team as a code owner January 29, 2025 12:46

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/analyze-action.ts:208

  • This newly introduced code path for unsetting environment variables should be verified by tests to ensure correct behavior and avoid regressions. Please add or update tests covering the scenario where CODEQL_PROXY_HOST is empty.
if (process.env.CODEQL_PROXY_HOST === "") {

src/start-proxy-action.ts:103

  • This early return for no credentials found should be included in test coverage to confirm the skipping of proxy setup does not introduce unexpected behavior. Please add or expand tests for this scenario.
if (credentials.length === 0) {

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@marcogario marcogario enabled auto-merge January 29, 2025 13:00
@marcogario marcogario merged commit 6e54559 into releases/v3 Jan 29, 2025
261 checks passed
@marcogario marcogario deleted the update-v3.28.7-797fb30ed branch January 29, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants