-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge main into releases/v3 #2743
Conversation
Mergeback v3.28.6 refs/heads/releases/v3 into main
start-proxy: Remove unusued proxy_password input
start-proxy: Skip proxy setup if no credentials are available
Revert "start-proxy: Skip proxy setup if no credentials are available"
Properly unset proxy env if empty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/analyze-action.ts:208
- This newly introduced code path for unsetting environment variables should be verified by tests to ensure correct behavior and avoid regressions. Please add or update tests covering the scenario where CODEQL_PROXY_HOST is empty.
if (process.env.CODEQL_PROXY_HOST === "") {
src/start-proxy-action.ts:103
- This early return for no credentials found should be included in test coverage to confirm the skipping of proxy setup does not introduce unexpected behavior. Please add or expand tests for this scenario.
if (credentials.length === 0) {
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
Merging 797fb30 into
releases/v3
.Conductor for this PR is @marcogario.
Contains the following pull requests:
Please do the following:
releases/v3
branch.Create a merge commit
is selected rather thanSquash and merge
orRebase and merge
.