Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "start-proxy: Skip proxy setup if no credentials are available" #2740

Merged
merged 1 commit into from
Jan 29, 2025
+1 −11
Merged

Revert "start-proxy: Skip proxy setup if no credentials are available" #2740

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Revert "start-proxy: Skip proxy setup if no credentials are available"
@marcogario
marcogario authored Jan 29, 2025
commit 7fdc1b8d67d77336151fe037c8c1f4d98db428d3
4 changes: 0 additions & 4 deletions lib/start-proxy-action.js
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/start-proxy-action.js.map
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 0 additions & 6 deletions src/start-proxy-action.ts
View file
Original file line number Diff line number Diff line change
@@ -99,12 +99,6 @@ async function runWrapper() {
actionsUtil.getOptionalInput("registries_credentials"),
actionsUtil.getOptionalInput("language"),
);

if (credentials.length === 0) {
logger.info("No credentials found, skipping proxy setup.");
return;
}

logger.info(
`Credentials loaded for the following registries:\n ${credentials
.map((c) => credentialToStr(c))