feat: resume interrupted CoValues sync on restart #3320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrainhart
commented
Dec 30, 2025
Comment on lines
181
to
+184
| peers?: Peer[]; | ||
| syncWhen?: SyncWhen; |
Contributor
Author
There was a problem hiding this comment.
I'd prefer both params to be part of a single SyncConfig object, but didn't want to introduce a breaking change in the local node API
gdorsi
reviewed
Dec 30, 2025
nrainhart
force-pushed
the
feat/resume-sync-on-restart
branch
from
baa818d to
ea38b24
Compare
gdorsi
reviewed
Jan 2, 2026
gdorsi
reviewed
Jan 2, 2026
gdorsi
reviewed
Jan 2, 2026
gdorsi
reviewed
Jan 2, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
nrainhart
force-pushed
the
feat/resume-sync-on-restart
branch
from
fd53d65 to
31f4e41
Compare
nrainhart
force-pushed
the
feat/resume-sync-on-restart
branch
from
4aa45bb to
bde3fee
Compare
Co-authored-by: Guido D'Orsi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, if CoValue sync is interrupted and the app is restarted, the sync process won't resume until the unsynced CoValue is loaded again.
This PR implements sync state tracking for CoValues in persistent storage, so that the sync process can be automatically resumed when the app restarts. Sync resumption is performed in batches, to avoid slowing down the performance of the app on startup.
Manual testing
Ran some performance testing in the browser to analyze the additional cost of tracking CoValue sync state. After applying some performance optimizations (persist pending sync updates in batches, minimize the number of times the sync state tracking callbacks are executed), managed to reduce it to what I consider a reasonable cost:
This measures the time it takes to create 10k tasks in the stress test app (which means creating 30k CoValues, including the tasks themselves, their group owners & their text content).
Tests
Checklist
Note
Introduces persisted tracking of unsynced
CoValues and automatic sync resumption after restart, focused on persistent server peers and batched writes for performance.UnsyncedCoValuesTrackerwith batched storage persistence, per-CoValue/global subscriptions, and flush ongracefulShutdownStorageAPIwithtrackCoValuesSyncState,getUnsyncedCoValueIDs,stopTrackingSyncStateunsyncedCoValuesstore, schema v5, CRUD inidbClient; SQLite: newunsynced_covaluestable + migrations and client methodsSyncManagerintegration:trackSyncState,resumeUnsyncedCoValues()(batched), only track persistent server peers, resume duringstartPeerReconciliationSyncStateManager.subscribeToPeerUpdatesnow keyed by(peerId, coValueId); related call sites updatedLocalNode/contexts acceptsyncWhenand propagate; logout/shutdown now awaits tracker flushWritten by Cursor Bugbot for commit 633321e. This will update automatically on new commits. Configure here.