fix: prevent concurrent logout attempts in ContextManager #3328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
gdorsi
force-pushed
the
feat/better-waitforsyncerrors
branch
from
455637c to
d46cffd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An Expo+Clerk user reported seeing the error "ERROR Existing session in use, creating new one" and some sync issues.
Debugging I found that on logout the ContextManager.logOut function was called twice, leading to a double call of
createContext.This was making the app account migration running twice, killing the sync before pushing data to the network leading to have a partial sync of the account data.
Doing a fix for the logOut issue by preventing concurrent calls, and the sync issue in general should be solved by #3320