fix(tests): avoid closing storage before shutting down test nodes #3344
+4
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Started seeing this console errors in tests after merging #3320:
They were caused by vitest
onTestFinishedhooks closing storage before the node shutdown was actually completed (which includes tracking the CoValues' sync state in persistent storage).Note
Ensures test nodes fully flush and persist sync state before storage is closed, preventing readonly DB errors during teardown.
onTestFinishedteardown async andawaitnode.gracefulShutdown()intestUtils.tsvitestand helper imports insync.garbageCollection.test.tsandsync.test.tsWritten by Cursor Bugbot for commit c2b0210. This will update automatically on new commits. Configure here.