Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve drag&drop #5273

Merged
merged 9 commits into from
Jun 20, 2021
Merged

Improve drag&drop #5273

merged 9 commits into from
Jun 20, 2021

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Jun 19, 2021 •
edited
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Added possibility to select drop action (copy or paste) by pressing Ctrl or Shift
  • Added support for dropping to recycle bin
  • Improve drop support from external programs
  • Fixes an issue where the timer to navigate to hovered folder did not stop
  • Fixes an issue where you could not drop in the current folder after hovering over a folder
  • Fixes an issue where you could not open an .exe file with arguments by dropping a file on it

Validation
How did you test these changes?

  • Built and ran the app

@gave92 gave92 marked this pull request as ready for review June 19, 2021 19:13
@gave92 gave92 force-pushed the improve_dragdrop branch from 7959b8e to 2734390 Compare June 19, 2021 19:53
@yaira2 yaira2 requested a review from winston-de June 20, 2021 02:31
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jun 20, 2021
@yaira2 yaira2 merged commit 956f133 into files-community:main Jun 20, 2021
This was referenced Jun 20, 2021
Closed
Closed
Closed
@yaira2
Copy link
Member

yaira2 commented Jun 20, 2021

@gave92 Thank you, nice work!

@gave92 gave92 deleted the improve_dragdrop branch June 20, 2021 04:58
This was referenced Jun 20, 2021
Open
Open
@cinqmilleans cinqmilleans mentioned this pull request Jun 20, 2021
Closed
@gave92 gave92 mentioned this pull request Apr 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

@winston-de winston-de winston-de approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
3 participants
@gave92 @yaira2 @winston-de