Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5270 #5279

Closed
wants to merge 1 commit into from
Closed

Fix #5270 #5279

wants to merge 1 commit into from

Conversation

cinqmilleans
Copy link
Contributor

Resolved / Related Issues
The commit #5273 remove the commit #4603.
The commit #4603 only has an effect in debugging and avoids having to relaunch Visual Studio for each modification.
This change cannot have any impact for the end user. This modification is very useful for developers.

Details of Changes
Apply the commit #4603.

@gave92
Copy link
Member

gave92 commented Jun 20, 2021

My bad, removed it b/c I needed to test app suspend/resume for that PR.

avoids having to relaunch Visual Studio for each modification

Never had this issue though :)

@yaira2
Copy link
Member

yaira2 commented Jun 20, 2021

Never had this issue though :)

Neither have I.

@yaira2 yaira2 requested a review from gave92 June 20, 2021 15:19
@gave92
Copy link
Member

gave92 commented Jun 20, 2021

This isn't needed for most people and makes testing some PRs (#5270, #5271) a bit annoying and makes using the Debug version outside VS (which I do) kinda annoying too (ever time I minimize the app I think it's crashed 😁). But anyway..

@gave92 gave92 added the ready to merge Pull requests that are approved and ready to merge label Jun 20, 2021
@yaira2
Copy link
Member

yaira2 commented Jun 20, 2021

@cinqmilleans Since it seems to be an uncommon issue, would it be possible for you to use Task Manager to force close Files when this issue occurs?

@cinqmilleans
Copy link
Contributor Author

@yaichenbaum @gave92
Maybe I solved the problem. I applied this, and it looks better.

  1. Expand Configuration Properties and then choose Debugging.
  2. For Visual C# and Visual Basic projects, choose Do not launch, but debug my code when it starts.

https://docs.microsoft.com/en-us/visualstudio/debugger/how-to-trigger-suspend-resume-and-background-events-for-windows-store-apps-in-visual-studio?view=vs-2019

@yaira2
Copy link
Member

yaira2 commented Jun 20, 2021

@cinqmilleans Great! Can I close this pull request now?

@cinqmilleans
Copy link
Contributor Author

@yaichenbaum Yes, it’s ok for me. I close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants