Use chroots from augmented config in snapshot_manager#1148
Merged
kwk merged 4 commits intogh/kwk/4/basefrom Mar 11, 2025
Merged
Use chroots from augmented config in snapshot_manager#1148kwk merged 4 commits intogh/kwk/4/basefrom
kwk merged 4 commits intogh/kwk/4/basefrom
Conversation
This was referenced Mar 6, 2025
Merged
tuliom
approved these changes
Mar 11, 2025
kwk
added a commit
that referenced
this pull request
Mar 11, 2025
In a previous commit we ensured that a `config.Config` object not only knows about the `chroot_pattern` but also can carry the resolved `chroots` (#1145) that match this pattern. The methods to filter and sanitize chroots was added in (#1146). In this change we make use of the `config.Config.chroots` and remove the need to fetch and filter. ghstack-source-id: 9e103ac Pull Request resolved: #1148
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
In a previous commit we ensured that a
config.Configobject not onlyknows about the
chroot_patternbut also can carry the resolvedchroots(#1145) that match this pattern. The methods to filter andsanitize chroots was added in (#1146).
In this change we make use of the
config.Config.chrootsand remove theneed to fetch and filter.