Merged
Conversation
This was referenced Mar 6, 2025
tuliom
requested changes
Mar 7, 2025
Collaborator
tuliom
left a comment
tuliom
left a comment
There was a problem hiding this comment.
The code itself LGTM, but as with the previous PR, I think it's important to mention in the commit message this code is not being used right now, but is laying the ground for a future transition.
tuliom
approved these changes
Mar 10, 2025
kwk
added a commit
that referenced
this pull request
Mar 11, 2025
* `serialize_config_map_to_github_matrix` * `augment_config_map_with_chroots` * `augment_config_with_chroots` * `sanitize_chroots` * `filter_chroots` These function will be used in a later commit and serve the purpose of having a single point of truth in python to drive github workflows. ghstack-source-id: 63a23d1 Pull Request resolved: #1146
kwk
added a commit
that referenced
this pull request
Mar 11, 2025
In a previous commit we ensured that a `config.Config` object not only knows about the `chroot_pattern` but also can carry the resolved `chroots` (#1145) that match this pattern. The methods to filter and sanitize chroots was added in (#1146). In this change we make use of the `config.Config.chroots` and remove the need to fetch and filter. ghstack-source-id: 9e103ac Pull Request resolved: #1148
kwk
added a commit
that referenced
this pull request
Mar 11, 2025
In preparation to get rid of the `scripts/functions.sh` (#1151) these are the newly added commands to the `main` program: * `get-chroots` * `delete-project` (see also #1147) * `github-matrix` (see also `serialize_config_map_to_github_matrix` from #1146) * `has_all_good_builds` (see also #1147) These new commands implement functionality that was previously only available in bash in `scripts/functions.sh`. ghstack-source-id: 9fef394 Pull Request resolved: #1149
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Add utility functions
serialize_config_map_to_github_matrixaugment_config_map_with_chrootsaugment_config_with_chrootssanitize_chrootsfilter_chrootsThese function will be used in a later commit and serve the purpose of
having a single point of truth in python to drive github workflows.