Refactor and test copr_util module#1147
Merged
kwk merged 4 commits intogh/kwk/3/basefrom Mar 11, 2025
Merged
Conversation
This was referenced Mar 6, 2025
Merged
tuliom
approved these changes
Mar 10, 2025
kwk
added a commit
that referenced
this pull request
Mar 11, 2025
In preparation to get rid of the `scripts/functions.sh` (#1151) these are the newly added commands to the `main` program: * `get-chroots` * `delete-project` (see also #1147) * `github-matrix` (see also `serialize_config_map_to_github_matrix` from #1146) * `has_all_good_builds` (see also #1147) These new commands implement functionality that was previously only available in bash in `scripts/functions.sh`. ghstack-source-id: 9fef394 Pull Request resolved: #1149
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Add methods from
scripts/functions.shto python:has_all_good_buildsdelete_projectThese functions will be used in a later commit. The goal is to do most
of the analyis of copr builds in Python and not in bash in
scripts/functions.sh.