Change requests #25 #28 #30 #31 #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified `src/signals/models.py` to include an ordering attribute in the Meta class
- Added `id` column to the signal list table in the `signal_list.html` file. - Modified the table structure to include the `id` column. - Updated the table row to display the `id` value for each signal.
- Added 'active' field to the SignalFilter class in filters.py - Modified signal_list.html to include a dropdown menu for the 'active' field
- Modified `src/templates/index.html` to update the header section to move sidebar btn
melange396
requested changes
Oct 17, 2023
- Deleted the "id" column from the table in the file "signal_list.html" in the "src/templates/signals" directory.
- Added `ordering` attribute to the `SourceSubdivision` model to specify the default ordering of instances based on the `name` field. - Added `ordering` attribute to the `DataSource` model to specify the default ordering of instances based on the `name` field.
- Modified signal_list.html to update the table headers and link to the base signal. - Updated the table header "Signal" to "Base Signal". - Updated the table header "Link" to "Links". - Added a link to the base signal in the "Base Signal" column.
- Modified `test_views.py` to change the loop variable from `i` to `_` in the `setUp` method. - Modified `urls.py` to specify that the `pk` parameter in the URL pattern for the `SignalsDetailView` should be an integer. - Modified `signal_list.html` to add a conditional statement that checks if `signal.base` exists before displaying the link to the detail view.
|
@melange396 also dccdd3b :
|
- Added `src/templates/index.html` - Modified `src/templates/index.html` to include a class `toggle-sidebar` in the `body` tag
minhkhul
approved these changes
Oct 30, 2023
- Added `src/signals/migrations/0004_rename_format_signal_format_type.py` - Modified `src/signals/admin.py` to change `format` to `format_type` - Modified `src/signals/filters.py` to change `format` to `format_type` - Modified `src/signals/models.py` to change `format` to `format_type` - Modified `src/signals/tests/factories.py` to change `format` to `format_type` - Added `src/signals/tests/test_api.py` to test the API view for the signal list - Modified `src/signals/views.py` to change `format` to `format_type` - Modified `src/templates/signals/signal_detail.html` to change `signal.format` to `signal.format_type` - Modified `src/templates/signals/signal_list.html` to change `filter.form.format` to `filter.form.format_type`
- Added `bootstrap.min.css` file from the CDN link. - Modified `index.html` to include the `bootstrap.min.css` file with its integrity and crossorigin attributes. - Modified `index.html` to include the `bootstrap.bundle.min.js` file with its integrity and crossorigin attributes. - Modified `signal_list.html` to add a new button with the id `collapseButton` and the necessary attributes for collapsing and expanding content. - Modified `signal_list.html` to add a new div with the class `collapse` and the id `collapseExample` for the collapsible content. - Modified `signal_list.html` to modify the table row click event to include a backslash before the semicolon. - Modified `signal_list.html` to add a closing `</selectright>` tag. - Modified `signal_list.html` to add a closing `</style>` tag. - Deleted unused code and empty lines.
- Removed the "Available geography" column from the signal_list.html template. - Removed the "Signal Type" column from the signal_list.html template. - Removed the "Format" column from the signal_list.html template. - Removed the "Temporal Resolution" column from the signal_list.html template. - Removed the "Links" column from the signal_list.html template.
- Deleted `test_api.py` file in `src/signals/tests` directory.
…cumentation into change-requests-#25-#28-#30-#31
This was referenced Nov 20, 2023
This was
linked to
issues
Nov 20, 2023
…cumentation into change-requests-#25-#28-#30-#31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change requests from #25 #28 #30 #31 #36 #37 issues
src/signals/models.pyto include an ordering attribute in the Meta classidcolumn to the signal list table in thesignal_list.htmlfile.idcolumn.idvalue for each signal.src/templates/index.htmlto update the header section to move the sidebar button