Skip to content

Allow filtering on "active" signals #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
melange396 opened this issue Oct 16, 2023 · 1 comment · Fixed by #32
Closed

Allow filtering on "active" signals #30

melange396 opened this issue Oct 16, 2023 · 1 comment · Fixed by #32
Assignees
@BrainIsDead

Comments

@melange396
Copy link
Collaborator

There is an active column in the old signals spreadsheet, and it looks like its incorporated in the model here.

For instance, https://staging/signals/signals/905/ (safegraph-daily / "Part Time Work/School") lists in its description that it was "Discontinued April 19th, 2021". All of our fb-survey signals are currently inactive. Such information is very likely to be valuable to a researcher browsing for signals.

We may possibly want to display this as a column in the main list-of-signals view, and definitely want to show it on an individual signal's detail page.
@BrainIsDead BrainIsDead self-assigned this Oct 17, 2023
@BrainIsDead BrainIsDead mentioned this issue Oct 17, 2023
Merged
@BrainIsDead
Copy link
Collaborator

Done

BrainIsDead pushed a commit that referenced this issue Nov 17, 2023
Merge branch 'development' of https://github.com/cmu-delphi/signal_do…
0f11250 
…cumentation into change-requests-#25-#28-#30-#31
@BrainIsDead BrainIsDead linked a pull request Nov 20, 2023 that will close this issue
Change requests #25 #28 #30 #31 #32
Merged
BrainIsDead added a commit that referenced this issue Nov 30, 2023
@BrainIsDead
Merge branch 'development' of https://github.com/cmu-delphi/signal_do…
98d51b1 
…cumentation into change-requests-#25-#28-#30-#31
BrainIsDead added a commit that referenced this issue Nov 30, 2023
@BrainIsDead
Merge branch 'change-requests-#25-#28-#30-#31' of https://github.com/…
a43224a 
…cmu-delphi/signal_documentation into change-requests-#25-#28-#30-#31
BrainIsDead added a commit that referenced this issue Nov 30, 2023
@BrainIsDead
Merge pull request #32 from cmu-delphi/change-requests-#25-#28-#30-#31
19e8cdb 
Change requests #25 #28 #30 #31 #37 #36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrainIsDead BrainIsDead

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change requests #25 #28 #30 #31 cmu-delphi/signal_documentation
2 participants
@melange396 @BrainIsDead