Skip to content

Change requests #25 #28 #30 #31 #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Nov 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
0d9d9d9
The changes made in this commit include:
BrainIsDead Oct 17, 2023
ec90ba6
The changes made in this commit include:
BrainIsDead Oct 17, 2023
54061d8
The changes made in this commit include:
BrainIsDead Oct 17, 2023
3253f14
The changes made in this commit include:
BrainIsDead Oct 17, 2023
6cdfb4e
The changes made in this commit include:
BrainIsDead Oct 18, 2023
0bef843
The changes made in this commit include:
BrainIsDead Oct 18, 2023
dccdd3b
The changes made in this commit include:
BrainIsDead Oct 18, 2023
98a232f
The changes made in this commit include:
BrainIsDead Oct 18, 2023
6b3c4bf
To summarize the changes made in this commit:
BrainIsDead Oct 30, 2023
490e78e
The changes made in this commit include:
BrainIsDead Nov 1, 2023
80dd971
The changes made in this commit include:
BrainIsDead Nov 13, 2023
754990c
Fixed collapse filters
dmytrotsko Nov 14, 2023
1f8a28c
Replaced <button> with <a>
dmytrotsko Nov 15, 2023
bd2fb5f
added animations to filters
Nov 17, 2023
f444d8a
The changes made in this commit include:
Nov 17, 2023
aeeac2b
deleted django-bootstrap-v5
Nov 17, 2023
8ad9be9
The changes made in this commit include:
Nov 17, 2023
0f11250
Merge branch 'development' of https://github.com/cmu-delphi/signal_do…
Nov 17, 2023
dc29d42
updated dependencies
Nov 17, 2023
98d51b1
Merge branch 'development' of https://github.com/cmu-delphi/signal_do…
BrainIsDead Nov 30, 2023
42be422
updatet pip lock
BrainIsDead Nov 30, 2023
a43224a
Merge branch 'change-requests-#25-#28-#30-#31' of https://github.com/…
BrainIsDead Nov 30, 2023
dd4e414
updated lock file
BrainIsDead Nov 30, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Pipfile
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ django-health-check = "*"
django-cors-headers = "*"
django-debug-toolbar = "*"
gunicorn = "*"
django-bootstrap-v5 = "*"
pygraphviz = "*"
factory-boy = "*"
linkpreview = "*"
django-redis = "*"
Expand Down
243 changes: 121 additions & 122 deletions Pipfile.lock

Large diffs are not rendered by default.

6 changes: 6 additions & 0 deletions src/datasources/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ class SourceSubdivision(TimeStampedModel):
on_delete=models.PROTECT
)

class Meta:
ordering: list[str] = ["name"]

def __str__(self) -> str:
"""
Returns the name of the source subdivision as a string.
Expand Down Expand Up @@ -80,6 +83,9 @@ class DataSource(TimeStampedModel):
related_name="data_sources"
)

class Meta:
ordering: list[str] = ["name"]

def __str__(self) -> str:
"""
Returns the name of the data source as a string.
Expand Down
1 change: 0 additions & 1 deletion src/signal_documentation/settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@
]

EXTERNAL_APPS: list[str] = [
'bootstrap5',
'corsheaders',
'debug_toolbar',
'django_extensions',
Expand Down
1 change: 1 addition & 0 deletions src/signals/filters.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ class Meta:
fields: list[str] = [
'search',
'pathogen',
'active',
'available_geography',
'signal_type',
'category',
Expand Down
1 change: 1 addition & 0 deletions src/signals/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ class SignalCategory(TimeStampedModel):
)

class Meta:
ordering: list[str] = ["name"]
verbose_name_plural: str = "signal categories"

def __str__(self) -> str:
Expand Down
52 changes: 0 additions & 52 deletions src/signals/tests/test_api.py

This file was deleted.

2 changes: 1 addition & 1 deletion src/signals/tests/test_views.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
class SignalListViewTest(TestCase):

def setUp(self):
for i in range(fake.random_int(min=1, max=100)):
for _ in range(fake.random_int(min=1, max=100)):
SignalFactory()

def test_signal_list_view(self):
Expand Down
4 changes: 2 additions & 2 deletions src/signals/urls.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@

urlpatterns: list[URLPattern] = [
path('', SignalsListView.as_view(), name='signals'),
path('signals/<int:pk>/', SignalsDetailView.as_view(), name='signal'),
path('signals/<pk>/', SignalsDetailView.as_view(), name='signal'),

# REST API
path('api/v1/signals/', SignalsListApiView.as_view(), name='signals_api'),

path('api/v1/signals/', SignalsListApiView.as_view(), name='signals_api')
]
1 change: 0 additions & 1 deletion src/templates/400.html
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{% extends "error.html" %}
{% load static %}
{% load bootstrap5 %}
{% load i18n %}

{% block content %}
Expand Down
1 change: 0 additions & 1 deletion src/templates/403.html
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{% extends "error.html" %}
{% load static %}
{% load bootstrap5 %}
{% load i18n %}

{% block content %}
Expand Down
1 change: 0 additions & 1 deletion src/templates/404.html
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{% extends "error.html" %}
{% load static %}
{% load bootstrap5 %}
{% load i18n %}

{% block content %}
Expand Down
1 change: 0 additions & 1 deletion src/templates/500.html
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{% extends "error.html" %}
{% load static %}
{% load bootstrap5 %}
{% load i18n %}

{% block content %}
Expand Down
4 changes: 0 additions & 4 deletions src/templates/error.html
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@
<link href="{% static 'assets/img/favicon.png' %}" rel="icon">
<link href="{% static 'assets/img/apple-touch-icon.png' %}" rel="apple-touch-icon">

<!-- Include Bootstrap CSS and JS files -->
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/[email protected]/dist/css/bootstrap.min.css">
<script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/js/bootstrap.bundle.min.js"></script>

<!-- Google Fonts -->
<link href="{% static 'https://fonts.gstatic.com' %}" rel="preconnect">
<link href="https://fonts.googleapis.com/css?family=Open+Sans:300,300i,400,400i,600,600i,700,700i|Nunito:300,300i,400,400i,600,600i,700,700i|Poppins:300,300i,400,400i,500,500i,600,600i,700,700i" rel="stylesheet">
Expand Down
11 changes: 2 additions & 9 deletions src/templates/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@


<head>
{% load bootstrap5 %}
{% bootstrap_css %}
{% bootstrap_javascript %}
<meta charset="utf-8">
<meta content="width=device-width, initial-scale=1.0" name="viewport">

Expand All @@ -19,10 +16,6 @@
<link href="{% static 'assets/img/favicon.png' %}" rel="icon">
<link href="{% static 'assets/img/apple-touch-icon.png' %}" rel="apple-touch-icon">

<!-- Include Bootstrap CSS and JS files -->
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/[email protected]/dist/css/bootstrap.min.css">
<script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/js/bootstrap.bundle.min.js"></script>

<!-- Google Fonts -->
<link href="{% static 'https://fonts.gstatic.com' %}" rel="preconnect">
<link href="https://fonts.googleapis.com/css?family=Open+Sans:300,300i,400,400i,600,600i,700,700i|Nunito:300,300i,400,400i,600,600i,700,700i|Poppins:300,300i,400,400i,500,500i,600,600i,700,700i" rel="stylesheet">
Expand All @@ -48,17 +41,17 @@
======================================================== -->
</head>

<body>
<body class="toggle-sidebar">

<!-- ======= Header ======= -->
<header id="header" class="header fixed-top d-flex align-items-center">

<div class="d-flex align-items-center justify-content-between">
<i class="bi bi-list toggle-sidebar-btn"></i>
<a href="{% url 'signals' %}" class="logo d-flex align-items-center">
<img assets/img/logo.png" alt="">
<span class="d-none d-lg-block">Signal Documentation</span>
</a>
<i class="bi bi-list toggle-sidebar-btn"></i>
</div><!-- End Logo -->

<nav class="header-nav ms-auto">
Expand Down
1 change: 0 additions & 1 deletion src/templates/signals/signal_detail.html
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{% extends "index.html" %}

{% load bootstrap5 %}
{% load i18n %}
{% block content %}
<main id="main" class="main">
Expand Down
Loading