Remove preloaded disposables on test tearDown #748
Conversation
ben-grande
force-pushed
the
preload-fix-dirty-shutdown
branch
from
0245589 to
08c0f58
Compare
ben-grande
force-pushed
the
preload-fix-dirty-shutdown
branch
from
08c0f58 to
cf3aa2c
Compare
If it is not done on the test, it will be handled by "qubes/tests/__init__.py", which will attempt to kill the domain. If the preloaded disposable was still starting, exceptions will be handled by also attempting to kill the domain. Both methods will trigger the "_bare_cleanup()", sometimes indirectly via "cleanup()" or "_auto_cleanup()", but if "_bare_cleanup()" happens on the other call, not the one that called kill, it will not await and will attempt to remove the domain from the disk while it is still running (not completely killed). For: QubesOS#742 For: QubesOS/qubes-issues#1512 Fixes: QubesOS/qubes-issues#10369
ben-grande
force-pushed
the
preload-fix-dirty-shutdown
branch
from
cf3aa2c to
0fb2195
Compare
|
Noticed an error and OpenQA is in progress but dispvm job hasn't started yet. Do you think it can upload a new package and update in the meantime to be used on the same test and not have to wait for another one? |
|
PipelineRetryFailed |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #748 +/- ##
==========================================
- Coverage 70.43% 70.36% -0.08%
==========================================
Files 61 61
Lines 13755 13751 -4
==========================================
- Hits 9689 9676 -13
- Misses 4066 4075 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Nope, too late, will be in another run. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025110513-4.3&flavor=pull-requests Test run included the following:
Upload failures
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025081011-4.3&flavor=update
Failed tests24 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/149225#dependencies 81 fixed
Unstable testsPerformance TestsPerformance degradation:18 performance degradations
Remaining performance tests:157 tests
|
|
Volume in use was raised for 2 tests, |
| if not self.auto_cleanup or ( | ||
| force and not running and self.auto_cleanup | ||
| ): | ||
| await self._auto_cleanup(force=force) |
There was a problem hiding this comment.
Isn't self._auto_cleanup(force=True) more or less just self._bare_cleanup()? And self._preload_cleanup() will be called as part of remove from disk handler.
There was a problem hiding this comment.
Isn't self._auto_cleanup(force=True) more or less just self._bare_cleanup()?
Seems so, merging them.
And self._preload_cleanup() will be called as part of remove from disk handler.
On a best effort basis there for the case where a disposable is automatically removed from the system upon system startup and qubes startup. There may not be self.name there anymore.
ben-grande
force-pushed
the
preload-fix-dirty-shutdown
branch
from
4e718e4 to
36151bd
Compare
|
The bot posted info from the last run that finished, not the last run that was scheduled. Because the last run that finished took a long time to finish and was scheduled prior to the last run, it contains outdated commits.
From 2025110502-4.3: Details
|
Relying simple on domain not being running resulted in storage errors of attempting to remove it while still in use (domain still running). Didn't identify the cause, which is unfortunate as now it requires an extra parameter. For: QubesOS#742 For: QubesOS/qubes-issues#1512 Fixes: QubesOS/qubes-issues#10369
ben-grande
force-pushed
the
preload-fix-dirty-shutdown
branch
from
36151bd to
f1cbf21
Compare
|
Most recent run also failed to upload details, but there is a log: https://openqa.qubes-os.org/tests/158674/file/system_tests-tests.log Details
|
|
https://openqa.qubes-os.org/tests/158674/file/system_tests-var_log.tar.gz Debian template OOM while updating?
|
|
@ben-grande Possibly relevant, Thunderbird is no longer installed on Whonix-Workstation by default, so I'd guess that's why the test that searches for a Thunderbird window fails. |
4 participants
If it is not done on the test, it will be handled by "qubes/tests/init.py", which will attempt to kill the domain. If the preloaded disposable was still starting, exceptions will be handled by also attempting to kill the domain. Both methods will trigger the "_bare_cleanup()", sometimes indirectly via "cleanup()" or "_auto_cleanup()", but if "_bare_cleanup()" happens on the other call, not the one that called kill, it will not await and will attempt to remove the domain from the disk while it is still running (not completely killed).
For: #742
For: QubesOS/qubes-issues#1512
Fixes: QubesOS/qubes-issues#10369