Update qubesdb first on keyboard layout change #747
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #747 +/- ##
==========================================
- Coverage 70.40% 70.37% -0.03%
==========================================
Files 61 61
Lines 13682 13757 +75
==========================================
+ Hits 9633 9682 +49
- Misses 4049 4075 +26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Note for the reviewer(s): Maybe we should consider to do not do anything in |
|
Maybe we should consider to do not do anything in `on_keyboard_set` if `newvalue == oldvalue` and it should just return (since nothing is actually changed?).
That might be a good idea indeed.
…--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
|
It is better to update `keyboard-layout` of GUIVM in qubesdb before propagating the layout change to its child qubes. While this does not fix the original layout change propagation bug (there is another PR for that). It is still more logical related: QubesOS/qubes-issues#8441 related: QubesOS/qubes-issues#6517
alimirjamali
force-pushed
the
issue-6517-8441-keyboard-layout
branch
from
b106377 to
c139c35
Compare
Applied to the amended patch |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025110513-4.3&flavor=pull-requests Test run included the following:
Upload failures
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025081011-4.3&flavor=update
Failed tests24 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/149225#dependencies 81 fixed
Unstable testsPerformance TestsPerformance degradation:18 performance degradations
Remaining performance tests:157 tests
|
3 participants
It is better to update
keyboard-layoutof GUIVM in qubesdb before propagating the layout change to its child qubes.While this does not fix the original layout change propagation bug (there is another PR for that). It is still more logical
related: QubesOS/qubes-issues#8441
related: QubesOS/qubes-issues#6517