-
-
Notifications
You must be signed in to change notification settings - Fork 80
Cache device assignments/attachments #394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Those are enumerated several times when listing devices, but they change rarely (most qubes don't get any devices attached usually). Cache both assignments and attachments to speed things up. And similarly to properties and power state cache - invalidate the cache based on events. Fixes QubesOS/qubes-issues#10380
While it doesn't enable events to have proper cache invalidation, it's also short lived program that can speed up by avoiding repeated enumeration.
4d5cff2 to
5370803
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #394 +/- ##
==========================================
+ Coverage 76.17% 76.19% +0.02%
==========================================
Files 53 53
Lines 9250 9289 +39
==========================================
+ Hits 7046 7078 +32
- Misses 2204 2211 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025110513-4.3&flavor=pull-requests Test run included the following:
Upload failures
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025081011-4.3&flavor=update
Failed tests24 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/149225#dependencies 81 fixed
Unstable testsPerformance TestsPerformance degradation:18 performance degradations
Remaining performance tests:157 tests
|
Those are enumerated several times when listing devices, but they change
rarely (most qubes don't get any devices attached usually). Cache both
assignments and attachments to speed things up. And similarly to properties
and power state cache - invalidate the cache based on events.
Fixes QubesOS/qubes-issues#10380