[Feature] Add Header::from_bytes_le_unchecked
#2951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaimast
force-pushed
the
feat/block-header-from-unchecked
branch
from
d48915e to
a305f71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
Header::from_byts_le_uncheckedandMetadata::from_bytes_le_unchecked. These variants skip any validity checks for data. This is needed for snarkOS PR #3925.All functionality changes of the PR are contained in the first commit. The second commit only adds tests.
The tests were changes to also tests testnet deserialization, and not just mainnet. Some tests are skipped when the
test_targetsfeatures is disabled.