[Fix] Ensure the developer scan command works on devnets
#3925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicsn
reviewed
Oct 9, 2025
| let is_development_network = genesis_block != Block::from_bytes_le(N::genesis_bytes())?; | ||
| // Use the unchecked version to allow loading the regular genesis block, even if the CLI | ||
| // has `test_targets` enabled. | ||
| let is_development_network = genesis_block != Block::from_bytes_le_unchecked(N::genesis_bytes())?; |
Collaborator
There was a problem hiding this comment.
test_network/test_targets are a dev-only feature.
I think the simplest change to fix scanning is to just assume we are on a development network if the test_network feature is enabled. And that also implies that the queried network has it enabled, because we were able to deserialize it's genesis block.
Generally I think it's good if we very tightly couple the concept of "dev" and "test_network", maybe even being the same thing one day.
Contributor
Author
There was a problem hiding this comment.
Sure, I can change it to that if you prefer.
Collaborator
There was a problem hiding this comment.
Yes please, let's aim for minimal and quick PRs that focus on getting the issue at hand solved.
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: snarkVM PR #2951 needs to be merged first.
Most recent snarkVM breaks the devnet CI, because
developer scandoes not work withtest_targetsenabled.This is due to recent changes ensuring that the genesis block is valid when deserializing it. This PR changes the scan command to use
from_bytes_uncheckedwhen loading the genesis bytes.The change is safe because the bytes are hardcoded and, thus, from a trusted source.