test(ledger/block): add tests for deserializing genesis bytes with test_targets enabled

Author: kaimast

console/network/src/lib.rs

@@ -298,6 +298,9 @@ pub trait Network:
     fn INCLUSION_UPGRADE_HEIGHT() -> Result<u32>;
 
     /// Returns the genesis block bytes.
+    ///
+    /// Note, that this always returns the bytes of the production genesis block.
+    /// As a result, this may not match the bytes of the genesis block with the `test_targets` feature enabled.
     fn genesis_bytes() -> &'static [u8];
 
     /// Returns the restrictions list as a JSON-compatible string.

ledger/Cargo.toml

@@ -84,6 +84,7 @@ test-helpers = [
 ]
 test_targets = [
   "snarkvm-console/test_targets",
+  "snarkvm-ledger-block/test_targets",
 ]
 timer = [ "aleo-std/timer" ]
 

ledger/block/Cargo.toml

@@ -36,6 +36,7 @@ wasm = [
 ]
 test = [ "snarkvm-synthesizer-process/test" ]
 test-helpers = [ ]
+test_targets = [ "snarkvm-console/test_targets" ]
 
 [dependencies.snarkvm-console]
 workspace = true

ledger/block/src/bytes.rs

@@ -152,9 +152,7 @@ impl<N: Network> ToBytes for Block<N> {
 #[cfg(test)]
 mod tests {
     use super::*;
-    use console::network::MainnetV0;
-
-    type CurrentNetwork = MainnetV0;
+    use console::network::{MainnetV0, TestnetV0};
 
     #[test]
     fn test_bytes() -> Result<()> {
@@ -170,28 +168,58 @@ mod tests {
     }
 
     #[test]
-    fn test_genesis_bytes() -> Result<()> {
+    fn test_genesis_bytes_mainnet_unchecked() -> Result<()> {
         // Load the genesis block.
-        let genesis_block = Block::<CurrentNetwork>::read_le(CurrentNetwork::genesis_bytes()).unwrap();
+        let genesis_block = Block::<MainnetV0>::read_le_unchecked(MainnetV0::genesis_bytes()).unwrap();
 
         // Check the byte representation.
         let expected_bytes = genesis_block.to_bytes_le()?;
-        assert_eq!(genesis_block, Block::read_le(&expected_bytes[..])?);
         assert_eq!(genesis_block, Block::read_le_unchecked(&expected_bytes[..])?);
 
         Ok(())
     }
 
     #[test]
-    fn test_bincode() -> Result<()> {
+    fn test_genesis_bytes_testnet_unchecked() -> Result<()> {
         // Load the genesis block.
-        let genesis_block = Block::<CurrentNetwork>::read_le(CurrentNetwork::genesis_bytes()).unwrap();
+        let genesis_block = Block::<TestnetV0>::read_le_unchecked(TestnetV0::genesis_bytes()).unwrap();
 
-        let bincode_data = bincode::serialize(&genesis_block)?;
-        let block = bincode::deserialize(&bincode_data)?;
+        // Check the byte representation.
+        let expected_bytes = genesis_block.to_bytes_le()?;
+        assert_eq!(genesis_block, Block::read_le_unchecked(&expected_bytes[..])?);
 
-        assert_eq!(genesis_block, block);
+        Ok(())
+    }
+
+    #[test]
+    fn test_genesis_bytes_mainnet() -> Result<()> {
+        // Load the genesis block.
+        let genesis_block = Block::<MainnetV0>::read_le(MainnetV0::genesis_bytes()).unwrap();
+
+        // Check the byte representation.
+        let expected_bytes = genesis_block.to_bytes_le()?;
+        assert_eq!(genesis_block, Block::read_le(&expected_bytes[..])?);
+        assert_eq!(genesis_block, Block::read_le_unchecked(&expected_bytes[..])?);
 
         Ok(())
     }
+
+    // When `test_targets` is enabled, the gensis bytes do not match the expected coinbase target.
+    // (except for Mainnet which ignores this feature)
+    #[cfg(not(feature = "test_targets"))]
+    mod production {
+        use super::*;
+        #[test]
+        fn test_genesis_bytes_testnet() -> Result<()> {
+            // Load the genesis block.
+            let genesis_block = Block::<TestnetV0>::read_le(TestnetV0::genesis_bytes()).unwrap();
+
+            // Check the byte representation.
+            let expected_bytes = genesis_block.to_bytes_le()?;
+            assert_eq!(genesis_block, Block::read_le(&expected_bytes[..])?);
+            assert_eq!(genesis_block, Block::read_le_unchecked(&expected_bytes[..])?);
+
+            Ok(())
+        }
+    }
 }

ledger/block/src/serialize.rs

@@ -125,9 +125,47 @@ mod tests {
     }
 
     #[test]
-    fn test_genesis_bincode() -> Result<()> {
+    fn test_genesis_bincode_unchecked_mainnet() -> Result<()> {
+        let genesis_block = Block::<MainnetV0>::read_le_unchecked(MainnetV0::genesis_bytes()).unwrap();
+
+        // Serialize
+        let expected_bytes = genesis_block.to_bytes_le()?;
+        let expected_bytes_with_size_encoding = bincode::serialize(&genesis_block)?;
+        assert_eq!(&expected_bytes[..], &expected_bytes_with_size_encoding[8..]);
+
+        // Deserialize
+        assert_eq!(genesis_block, Block::read_le_unchecked(&expected_bytes[..])?);
+        assert_eq!(
+            genesis_block,
+            snarkvm_utilities::bytes::unchecked_deserialize(&expected_bytes_with_size_encoding[..])?
+        );
+
+        Ok(())
+    }
+
+    #[test]
+    fn test_genesis_bincode_unchecked_testnet() -> Result<()> {
+        let genesis_block = Block::<TestnetV0>::read_le_unchecked(TestnetV0::genesis_bytes()).unwrap();
+
+        // Serialize
+        let expected_bytes = genesis_block.to_bytes_le()?;
+        let expected_bytes_with_size_encoding = bincode::serialize(&genesis_block)?;
+        assert_eq!(&expected_bytes[..], &expected_bytes_with_size_encoding[8..]);
+
+        // Deserialize
+        assert_eq!(genesis_block, Block::read_le_unchecked(&expected_bytes[..])?);
+        assert_eq!(
+            genesis_block,
+            snarkvm_utilities::bytes::unchecked_deserialize(&expected_bytes_with_size_encoding[..])?
+        );
+
+        Ok(())
+    }
+
+    #[test]
+    fn test_genesis_bincode_mainnet() -> Result<()> {
         // Load the genesis block.
-        let genesis_block = Block::<CurrentNetwork>::read_le(CurrentNetwork::genesis_bytes()).unwrap();
+        let genesis_block = Block::<MainnetV0>::read_le(MainnetV0::genesis_bytes()).unwrap();
 
         // Serialize
         let expected_bytes = genesis_block.to_bytes_le()?;
@@ -140,4 +178,28 @@ mod tests {
 
         Ok(())
     }
+
+    // When `test_targets` is enabled, the gensis bytes do not match the expected coinbase target.
+    // (except for Mainnet which ignores this feature)
+    #[cfg(not(feature = "test_targets"))]
+    mod production {
+        use super::*;
+
+        #[test]
+        fn test_genesis_bincode_testnet() -> Result<()> {
+            // Load the genesis block.
+            let genesis_block = Block::<TestnetV0>::read_le(TestnetV0::genesis_bytes()).unwrap();
+
+            // Serialize
+            let expected_bytes = genesis_block.to_bytes_le()?;
+            let expected_bytes_with_size_encoding = bincode::serialize(&genesis_block)?;
+            assert_eq!(&expected_bytes[..], &expected_bytes_with_size_encoding[8..]);
+
+            // Deserialize
+            assert_eq!(genesis_block, Block::read_le(&expected_bytes[..])?);
+            assert_eq!(genesis_block, bincode::deserialize(&expected_bytes_with_size_encoding[..])?);
+
+            Ok(())
+        }
+    }
 }