Skip to content

Commit

Permalink
Fix incorrect types for WandbConfig (#410)
Browse files Browse the repository at this point in the history
Corrects the config by setting optional fields to actually be optional.

---------

Signed-off-by: Steven Kothen-Hill <[email protected]>
Co-authored-by: Farhad Ramezanghorbani <[email protected]>
  • Loading branch information
skothenhill-nv and farhadrgh authored Nov 8, 2024
1 parent 631e5de commit 95028cf
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,14 @@ class WandbConfig(BaseModel):
anonymous: Enables or explicitly disables anonymous logging.
""" # noqa: D205

entity: str # The team posting this run (default: your username or your default team)
entity: str | None # The team posting this run (default: your username or your default team)
project: str # The name of the project to which this run will belong.
# name: #Display name for the run. "This is handled by NeMoLogger"
# save_dir: #Path where data is saved. "This is handled by NeMoLogger"
tags: List[str] # Tags associated with this run.
group: str # A unique string shared by all runs in a given group
tags: List[str] | None # Tags associated with this run.
group: str | None # A unique string shared by all runs in a given group
offline: bool # Run offline (data can be streamed later to wandb servers).
id: str # Sets the version, mainly used to resume a previous run.
id: str | None # Sets the version, mainly used to resume a previous run.
anonymous: bool # Enables or explicitly disables anonymous logging.
log_model: bool # Save checkpoints in wandb dir to upload on W&B servers.

Expand Down

0 comments on commit 95028cf

Please sign in to comment.