Send roll, pitch and throttle commands to Arduplane #132
+310
−58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Arduplane 3.7, it is possible to command roll, pitch and throttle directly through GUIDED mode. The main benefit are
This adds some more complexity to the consume controlLoops functions: When CL_ROLL is activated, it is no longer necessarily the case that we are going to use FBWB, since we could also be going into this new GUIDED mode. The second commit here includes a state machine that causes the task to wait for a predescribed time, CLtimeout, to see if more CL will arrive. If CL_PITCH arrives, we go into the new GUIDED mode, if not we go into FBWB. A similar issue occurs when in the new GUIDED mode and we receive a deactivation of CL_PITCH; should we go to FBWB, or are we waiting for a deactivation of CL_ROLL to stop using any of these controllers (and go into INIT)?
We have flown this on many occasions, and have found CLtimeout = 200 ms to work well for the X8. I have not been able to test this with your newly updated master code yet, since we have not merged that into our code yet, but this PR builds at least. Thought I'd post it now, so you can have a look, since we discussed this earlier today.