Fix: Strip None values from orthology mapping API response#1207
Open
Swargambharath987 wants to merge 1 commit intoIGS:develfrom
Open
Fix: Strip None values from orthology mapping API response#1207Swargambharath987 wants to merge 1 commit intoIGS:develfrom
Swargambharath987 wants to merge 1 commit intoIGS:develfrom
Conversation
Swargambharath987
force-pushed
the
fix/ortholog-mapping-strip-none
branch
from
b5c8b44 to
7f08870
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
#1150
The list comprehensions in both the GET and POST handlers of the orthologs API could include None values when normalize_gene() fails to find a match, which gets serialized
as null in the JSON response. Updated both comprehensions to filter out None results using a walrus operator guard.