Fix: NA groups being omitted from plotly plots#1208
Open
Swargambharath987 wants to merge 1 commit intoIGS:develfrom
Open
Fix: NA groups being omitted from plotly plots#1208Swargambharath987 wants to merge 1 commit intoIGS:develfrom
Swargambharath987 wants to merge 1 commit intoIGS:develfrom
Conversation
Member
|
Glad to see the contributions! Take care though, it seems you are adding commits which don't belong to this PR. |
Swargambharath987
force-pushed
the
fix/plotly-na-groups-omitted
branch
from
ec85423 to
7aa0fdf
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #888
The dataframe passed to plotly had NaN values in categorical obs columns, causing NA groups to be silently dropped and triggering a KeyError in plotly express. @adkinsrs
had attempted a simple fillna but left it commented out due to the error: 'Cannot setitem on a Categorical with a new category, set the categories first'.
Fixed by iterating over categorical columns and conditionally adding 'NA' as a category before filling, with a guard to avoid adding it if it already exists. Object
columns are handled with a plain fillna.